Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 3006173002: Use RaceChecker instead of ThreadChecker in remote_bitrate_estimator. (Closed)

Created:
3 years, 3 months ago by erikvarga1
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use RaceChecker instead of ThreadChecker in remote_bitrate_estimator. BUG=webrtc:7826 Review-Url: https://codereview.webrtc.org/3006173002 Cr-Commit-Position: refs/heads/master@{#19778} Committed: https://chromium.googlesource.com/external/webrtc/+/423227306112c4011a538bf87ae7f2534f39f724

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patchset 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
erikvarga1
3 years, 3 months ago (2017-09-06 15:03:27 UTC) #5
danilchap
lgtm https://codereview.webrtc.org/3006173002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h File webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h (right): https://codereview.webrtc.org/3006173002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h#newcode28 webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h:28: #include "webrtc/rtc_base/race_checker.h" move one line up (or run ...
3 years, 3 months ago (2017-09-06 15:15:44 UTC) #6
erikvarga1
https://codereview.webrtc.org/3006173002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h File webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h (right): https://codereview.webrtc.org/3006173002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h#newcode28 webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h:28: #include "webrtc/rtc_base/race_checker.h" On 2017/09/06 15:15:44, danilchap wrote: > move ...
3 years, 3 months ago (2017-09-06 15:21:28 UTC) #7
erikvarga1
Stefan, can you also take a look at this?
3 years, 3 months ago (2017-09-06 15:23:21 UTC) #9
stefan-webrtc
lgtm
3 years, 3 months ago (2017-09-11 15:02:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006173002/20001
3 years, 3 months ago (2017-09-11 15:52:05 UTC) #13
commit-bot: I haz the power
3 years, 3 months ago (2017-09-11 16:23:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/423227306112c4011a538bf87...

Powered by Google App Engine
This is Rietveld 408576698