Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(59)

Issue 3006133002: Update thread annotiation macros in rtc_base to use RTC_ prefix (Closed)

Created:
3 years, 5 months ago by danilchap
Modified:
3 years, 5 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update thread annotiation macros in rtc_base to use RTC_ prefix BUG=webrtc:8198 Review-Url: https://codereview.webrtc.org/3006133002 Cr-Commit-Position: refs/heads/master@{#19714} Committed: https://chromium.googlesource.com/external/webrtc/+/3c6abd200cb9865402c96466fafe6867730cb2be

Patch Set 1 #

Patch Set 2 : include thread_checker.h #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -89 lines) Patch
M webrtc/rtc_base/asyncinvoker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/rtc_base/bufferqueue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/rtc_base/criticalsection.h View 4 chunks +16 lines, -13 lines 0 comments Download
M webrtc/rtc_base/criticalsection.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/rtc_base/criticalsection_unittest.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M webrtc/rtc_base/event_tracer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/fakeclock.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/logging.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/rtc_base/messagequeue.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/rtc_base/messagequeue.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/rtc_base/physicalsocketserver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/race_checker.h View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/rtc_base/rate_limiter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/rtc_base/sequenced_task_checker.h View 1 chunk +6 lines, -5 lines 0 comments Download
M webrtc/rtc_base/sequenced_task_checker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/signalthread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/rtc_base/stream.h View 1 chunk +14 lines, -10 lines 0 comments Download
M webrtc/rtc_base/swap_queue.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/rtc_base/task_queue.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/task_queue_libevent.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/rtc_base/thread.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/thread_checker.h View 1 1 chunk +6 lines, -8 lines 0 comments Download
M webrtc/rtc_base/thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
danilchap
Update done using script (and then undoing changes in thread_annotations.h and thread_checkers.h where old macros ...
3 years, 5 months ago (2017-09-06 11:39:43 UTC) #2
kwiberg-webrtc
lgtm
3 years, 5 months ago (2017-09-06 11:52:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006133002/20001
3 years, 5 months ago (2017-09-06 11:52:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/7758) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 5 months ago (2017-09-06 11:54:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006133002/40001
3 years, 5 months ago (2017-09-06 12:03:31 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-09-06 12:46:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/3c6abd200cb9865402c96466f...

Powered by Google App Engine
This is Rietveld 408576698