Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 3006093002: Expose less targets in webrtc/rtc_tools in Chromium builds. (Closed)

Created:
3 years, 3 months ago by kjellander_webrtc
Modified:
3 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Expose less targets in webrtc/rtc_tools in Chromium builds. This should solve recent linking problems with frame_editor and also speed up the Chromium build a little. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3006093002 Cr-Commit-Position: refs/heads/master@{#19677} Committed: https://chromium.googlesource.com/external/webrtc/+/6af0cbf4b02da1faf01011da81d97e1e0593b2ca

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -130 lines) Patch
M webrtc/rtc_tools/BUILD.gn View 1 3 chunks +136 lines, -130 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
perkj_webrtc
Thanks lgtm
3 years, 3 months ago (2017-09-05 05:58:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006093002/20001
3 years, 3 months ago (2017-09-05 06:40:11 UTC) #5
commit-bot: I haz the power
3 years, 3 months ago (2017-09-05 06:42:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/6af0cbf4b02da1faf01011da8...

Powered by Google App Engine
This is Rietveld 408576698