Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 3006003002: RtpToNtpEstimator:: Add a DCHECK to avoid div-by-0 (Closed)

Created:
3 years, 3 months ago by hlundin-webrtc
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RtpToNtpEstimator:: Add a DCHECK to avoid div-by-0 The division that follows the added DCHECK should not be div-by-0, since when params_.calculated is true, params_.frequency_khz would have been updated (with something non-zero). BUG=none Review-Url: https://codereview.webrtc.org/3006003002 Cr-Commit-Position: refs/heads/master@{#19671} Committed: https://chromium.googlesource.com/external/webrtc/+/d56ef8085718e15c497b0d9c60baa1a4640420fa

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc View 2 chunks +4 lines, -0 lines 1 comment Download

Messages

Total messages: 23 (10 generated)
hlundin-webrtc
Karl, ptal.
3 years, 3 months ago (2017-09-01 12:50:29 UTC) #2
kwiberg-webrtc
lgtm https://codereview.webrtc.org/3006003002/diff/1/webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc File webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc (right): https://codereview.webrtc.org/3006003002/diff/1/webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc#newcode168 webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc:168: RTC_DCHECK_NE(params_.frequency_khz, 0.0); Is it OK if the value ...
3 years, 3 months ago (2017-09-01 12:53:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006003002/1
3 years, 3 months ago (2017-09-01 13:01:04 UTC) #5
hlundin-webrtc
On 2017/09/01 12:53:06, kwiberg-webrtc wrote: > lgtm > > https://codereview.webrtc.org/3006003002/diff/1/webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc > File webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc (right): > ...
3 years, 3 months ago (2017-09-01 13:02:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/25639)
3 years, 3 months ago (2017-09-01 13:29:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006003002/1
3 years, 3 months ago (2017-09-04 07:12:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/21579)
3 years, 3 months ago (2017-09-04 07:29:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006003002/1
3 years, 3 months ago (2017-09-04 07:40:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27377)
3 years, 3 months ago (2017-09-04 07:58:16 UTC) #16
oprypin_webrtc
On 2017/09/04 07:58:16, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 3 months ago (2017-09-04 09:13:07 UTC) #17
hlundin-webrtc
On 2017/09/04 09:13:07, oprypin_webrtc wrote: > On 2017/09/04 07:58:16, commit-bot: I haz the power wrote: ...
3 years, 3 months ago (2017-09-04 15:28:44 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006003002/1
3 years, 3 months ago (2017-09-04 15:29:05 UTC) #20
commit-bot: I haz the power
3 years, 3 months ago (2017-09-04 16:02:21 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d56ef8085718e15c497b0d9c6...

Powered by Google App Engine
This is Rietveld 408576698