RtpToNtpEstimator:: Add a DCHECK to avoid div-by-0

RtpToNtpEstimator:: Add a DCHECK to avoid div-by-0

The division that follows the added DCHECK should not be div-by-0,
since when params_.calculated is true, params_.frequency_khz would
have been updated (with something non-zero).

BUG=none

Review-Url: https://codereview.webrtc.org/3006003002
Cr-Commit-Position: refs/heads/master@{#19671}
Committed: https://chromium.googlesource.com/external/webrtc/+/d56ef8085718e15c497b0d9c60baa1a4640420fa

[hlundin-webrtc, 2017-09-01 12:50:28]

henrik.lundin@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[hlundin-webrtc, 2017-09-01 12:50:29]

Karl, ptal.

[kwiberg-webrtc, 2017-09-01 12:53:06]

lgtm

https://codereview.webrtc.org/3006003002/diff/1/webrtc/system_wrappers/source...
File webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc (right):

https://codereview.webrtc.org/3006003002/diff/1/webrtc/system_wrappers/source...
webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc:168:
RTC_DCHECK_NE(params_.frequency_khz, 0.0);
Is it OK if the value is very, very close to zero?

[hlundin-webrtc, 2017-09-01 13:00:55]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2017-09-01 13:01:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hlundin-webrtc, 2017-09-01 13:02:30]

On 2017/09/01 12:53:06, kwiberg-webrtc wrote:
> lgtm
> 
>
https://codereview.webrtc.org/3006003002/diff/1/webrtc/system_wrappers/source...
> File webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc (right):
> 
>
https://codereview.webrtc.org/3006003002/diff/1/webrtc/system_wrappers/source...
> webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc:168:
> RTC_DCHECK_NE(params_.frequency_khz, 0.0);
> Is it OK if the value is very, very close to zero?

Well...

Submitting after offline convo. YOLO.

[commit-bot: I haz the power, 2017-09-01 13:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-01 13:29:37]

Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/25639)

[hlundin-webrtc, 2017-09-04 07:12:46]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2017-09-04 07:12:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-04 07:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-04 07:29:44]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[hlundin-webrtc, 2017-09-04 07:40:11]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2017-09-04 07:40:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-04 07:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-04 07:58:16]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27377)

[oprypin_webrtc, 2017-09-04 09:13:07]

On 2017/09/04 07:58:16, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_dbg on master.tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27377)

The failures on Android trybots were fixed: crbug.com/761720
You can try the commit queue again.

[hlundin-webrtc, 2017-09-04 15:28:44]

On 2017/09/04 09:13:07, oprypin_webrtc wrote:
> On 2017/09/04 07:58:16, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   android_dbg on master.tryserver.webrtc (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27377)
> 
> The failures on Android trybots were fixed: crbug.com/761720
> You can try the commit queue again.

Thanks!

[hlundin-webrtc, 2017-09-04 15:28:50]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2017-09-04 15:29:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-04 16:02:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1504538930908570, "parent_rev":
"ba09f79ba31c543d0dcf3a6d824992685087005a", "commit_rev":
"d56ef8085718e15c497b0d9c60baa1a4640420fa"}

[commit-bot: I haz the power, 2017-09-04 16:02:20]

Description was changed from

==========
RtpToNtpEstimator:: Add a DCHECK to avoid div-by-0

The division that follows the added DCHECK should not be div-by-0,
since when params_.calculated is true, params_.frequency_khz would
have been updated (with something non-zero).

BUG=none
==========

to

==========
RtpToNtpEstimator:: Add a DCHECK to avoid div-by-0

The division that follows the added DCHECK should not be div-by-0,
since when params_.calculated is true, params_.frequency_khz would
have been updated (with something non-zero).

BUG=none

Review-Url: https://codereview.webrtc.org/3006003002
Cr-Commit-Position: refs/heads/master@{#19671}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d56ef8085718e15c497b0d9c6...
==========

[commit-bot: I haz the power, 2017-09-04 16:02:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d56ef8085718e15c497b0d9c6...