Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Issue 3005793002: Fix setting of recovered flag in RtxReceiveStream. (Closed)

Created:
3 years, 3 months ago by nisse-webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix setting of recovered flag in RtxReceiveStream. BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/3005793002 Cr-Commit-Position: refs/heads/master@{#19599} Committed: https://chromium.googlesource.com/external/webrtc/+/386449971a8f471e87f3844ebee1b1bc74144998

Patch Set 1 #

Patch Set 2 : Address feedback. #

Total comments: 3

Patch Set 3 : Add corresponding unit test. #

Total comments: 8

Patch Set 4 : Use .empty() instead of .size() == 0. #

Patch Set 5 : Drop static. git cl format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -14 lines) Patch
M webrtc/call/rtx_receive_stream.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/call/rtx_receive_stream.cc View 1 2 3 3 chunks +17 lines, -8 lines 0 comments Download
M webrtc/call/rtx_receive_stream_unittest.cc View 1 2 3 4 3 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
nisse-webrtc
PTAL. ps#1 is extracted from cl https://codereview.webrtc.org/3008773002/, ps#2. ps#2 addresses Danil's comments. Also needs a ...
3 years, 3 months ago (2017-08-29 14:12:29 UTC) #2
nisse-webrtc
I've added a unittest, and I hope to land this pretty soon. https://codereview.webrtc.org/3005793002/diff/20001/webrtc/call/rtx_receive_stream.cc File webrtc/call/rtx_receive_stream.cc ...
3 years, 3 months ago (2017-08-30 07:29:24 UTC) #3
danilchap
lgtm with optional nits https://codereview.webrtc.org/3005793002/diff/40001/webrtc/call/rtx_receive_stream.cc File webrtc/call/rtx_receive_stream.cc (right): https://codereview.webrtc.org/3005793002/diff/40001/webrtc/call/rtx_receive_stream.cc#newcode25 webrtc/call/rtx_receive_stream.cc:25: if (associated_payload_types_.size() == 0) { ...
3 years, 3 months ago (2017-08-30 07:54:21 UTC) #4
nisse-webrtc
https://codereview.webrtc.org/3005793002/diff/40001/webrtc/call/rtx_receive_stream.cc File webrtc/call/rtx_receive_stream.cc (right): https://codereview.webrtc.org/3005793002/diff/40001/webrtc/call/rtx_receive_stream.cc#newcode25 webrtc/call/rtx_receive_stream.cc:25: if (associated_payload_types_.size() == 0) { On 2017/08/30 07:54:21, danilchap ...
3 years, 3 months ago (2017-08-30 08:27:00 UTC) #5
brandtr
lgtm
3 years, 3 months ago (2017-08-30 08:43:18 UTC) #6
nisse-webrtc
Dropped static. Intend to land if the linux_internal bot is happy.
3 years, 3 months ago (2017-08-30 08:52:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3005793002/80001
3 years, 3 months ago (2017-08-30 08:54:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20952)
3 years, 3 months ago (2017-08-30 08:59:11 UTC) #12
nisse-webrtc
Stefan, please take an OWNER's look.
3 years, 3 months ago (2017-08-30 09:05:08 UTC) #14
stefan-webrtc
lgtm
3 years, 3 months ago (2017-08-30 10:46:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3005793002/80001
3 years, 3 months ago (2017-08-30 11:11:09 UTC) #17
commit-bot: I haz the power
3 years, 3 months ago (2017-08-30 11:16:48 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/386449971a8f471e87f3844eb...

Powered by Google App Engine
This is Rietveld 408576698