Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3005533003:
Add some unit tests to TestVp8Impl. (Closed)
|
Created:
3 years, 3 months ago by åsapersson Modified:
3 years, 3 months ago Reviewers:
brandtr CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd some unit tests to TestVp8Impl.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/3005533003
Cr-Commit-Position: refs/heads/master@{#19623}
Committed: https://chromium.googlesource.com/external/webrtc/+/f2972ba1665557fdec5691622c92c0aef869e0f1
Patch Set 1 #
Total comments: 20
Patch Set 2 : address comments #Patch Set 3 : remove WaitForDecodedFrame #Messages
Total messages: 26 (18 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
Description was changed from ========== Add some unit tests to TestVp8Impl. BUG=webrtc:6634 ========== to ========== Add some unit tests to TestVp8Impl. BUG=webrtc:6634 ==========
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org
Some comments. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:34: constexpr uint32_t kTestTimestamp = 123; kInitialRtpTimestamp? https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:36: constexpr int64_t kTimestampMs = 789; kInitialTimestampMs? https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:171: new VideoFrame(stride_buffer, kVideoRotation_0, Change to "preferred" ctor? Then you don't need to convert to us, but you do need to prove a render time. https://cs.chromium.org/chromium/src/third_party/webrtc/api/video/video_frame... https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:208: ASSERT_TRUE(false); RTC_NOTREACHED https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:217: ASSERT_TRUE(false); RTC_NOTREACHED https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:282: encoded_cb_.encoded_frame_.adapt_reason_.bw_resolutions_disabled); Is this field set/related to VP8Impl? https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:292: EncodeFrame(); is WaitForEncodedFrame() not needed here? Is it ever needed, due to the synchronous behaviour of libvpx? https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:296: EncodeFrame(); and here. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:365: EncodeFrame(); and here https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:446: } Might as well add a reinit here, and make this test into "EncoderWith3TemporalLayersRetainsRtpStateAfterRelease"?
Patchset #2 (id:140001) has been deleted
Patchset #2 (id:160001) has been deleted
Patchset #2 (id:180001) has been deleted
https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:34: constexpr uint32_t kTestTimestamp = 123; On 2017/08/30 09:08:17, brandtr wrote: > kInitialRtpTimestamp? Done. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:36: constexpr int64_t kTimestampMs = 789; On 2017/08/30 09:08:17, brandtr wrote: > kInitialTimestampMs? Done. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:171: new VideoFrame(stride_buffer, kVideoRotation_0, On 2017/08/30 09:08:17, brandtr wrote: > Change to "preferred" ctor? Then you don't need to convert to us, but you do > need to prove a render time. > > https://cs.chromium.org/chromium/src/third_party/webrtc/api/video/video_frame... Done. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:208: ASSERT_TRUE(false); On 2017/08/30 09:08:17, brandtr wrote: > RTC_NOTREACHED Done. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:217: ASSERT_TRUE(false); On 2017/08/30 09:08:17, brandtr wrote: > RTC_NOTREACHED Done. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:282: encoded_cb_.encoded_frame_.adapt_reason_.bw_resolutions_disabled); On 2017/08/30 09:08:17, brandtr wrote: > Is this field set/related to VP8Impl? Should be disabled for a single stream. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:292: EncodeFrame(); On 2017/08/30 09:08:18, brandtr wrote: > is WaitForEncodedFrame() not needed here? > > Is it ever needed, due to the synchronous behaviour of libvpx? Do not think it is ever needed, removed WaitForEncodedFrame and added check for EncodeComplete in EncodeFrame. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:446: } On 2017/08/30 09:08:17, brandtr wrote: > Might as well add a reinit here, and make this test into > "EncoderWith3TemporalLayersRetainsRtpStateAfterRelease"? Done.
lgtm, but please remove WaitForDecodedFrame too. https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:211: void WaitForDecodedFrame() { Then I guess this could be removed too?
https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/3005533003/diff/120001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:211: void WaitForDecodedFrame() { On 2017/08/30 11:07:17, brandtr wrote: > Then I guess this could be removed too? Done.
nice. lgtm again
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 220001, "attempt_start_ts": 1504173548277940,
"parent_rev": "e172d89f73775d81fa72d8aa18604fec30ce60d9", "commit_rev":
"f2972ba1665557fdec5691622c92c0aef869e0f1"}
Message was sent while issue was closed.
Description was changed from ========== Add some unit tests to TestVp8Impl. BUG=webrtc:6634 ========== to ========== Add some unit tests to TestVp8Impl. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3005533003 Cr-Commit-Position: refs/heads/master@{#19623} Committed: https://chromium.googlesource.com/external/webrtc/+/f2972ba1665557fdec5691622... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:220001) as https://chromium.googlesource.com/external/webrtc/+/f2972ba1665557fdec5691622... |
