Fix iOS API Framework build script after renaming objc targets.

Fix iOS API Framework build script after renaming objc targets.

This fixes the script after targets were renamed in
https://codereview.webrtc.org/3001023003/

BUG=webrtc:6412, chromium:758655
NOTRY=True

Review-Url: https://codereview.webrtc.org/3005513002
Cr-Commit-Position: refs/heads/master@{#19500}
Committed: https://chromium.googlesource.com/external/webrtc/+/72ba795e298fded0650d24fc698fe19d50df1b73

[kthelgason, 2017-08-24 14:03:00]

kthelgason@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-08-24 14:04:55]

Description was changed from

==========
Fix ios build script.

BUG=None
==========

to

==========
Fix iOS API Framework build script after renaming objc targets.

This fixes the script after targets were renamed in
https://codereview.webrtc.org/3001023003/

BUG=webrtc:6412
NOTRY=True
==========

[kjellander_webrtc, 2017-08-24 14:06:05]

lgtm, I updated the description for you.

wait for the trybot and also check it's build page, since there's a bug in
reporting failures on that particular step.

[kjellander_webrtc, 2017-08-24 14:18:31]

On 2017/08/24 14:06:05, kjellander_webrtc wrote:
> lgtm, I updated the description for you.
> 
> wait for the trybot and also check it's build page, since there's a bug in
> reporting failures on that particular step.

hmm, fails:

DEBUG:root:Running: ['gn', 'gen',
'/b/s/w/ir/cache/builder/ios_api_framework/src/out_ios_libs/arm64_libs',
'--args=target_os="ios" ios_enable_code_signing=false use_xcode_clang=true
is_component_build=false is_debug=false target_cpu="arm64"
ios_deployment_target="8.0" rtc_libvpx_build_vp9=false enable_ios_bitcode=true
use_goma=true goma_dir="/b/s/w/ir/cache/goma_client" enable_stripping=true']
Traceback (most recent call last):
  File
"/b/s/w/ir/cache/builder/ios_api_framework/src/tools_webrtc/ios/build_ios_libs.py",
line 255, in <module>
    sys.exit(main())
  File
"/b/s/w/ir/cache/builder/ios_api_framework/src/tools_webrtc/ios/build_ios_libs.py",
line 177, in main
    args.use_goma, gn_args, args.build_type == 'static_only')
  File
"/b/s/w/ir/cache/builder/ios_api_framework/src/tools_webrtc/ios/build_ios_libs.py",
line 123, in BuildWebRTC
    _RunCommand(cmd)
  File
"/b/s/w/ir/cache/builder/ios_api_framework/src/tools_webrtc/ios/build_ios_libs.py",
line 75, in _RunCommand
    subprocess.check_call(cmd, cwd=WEBRTC_SRC_DIR)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 535, in check_call
    retcode = call(*popenargs, **kwargs)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 710, in __init__
    errread, errwrite)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 1335, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

so not lgtm yet.

[kjellander_webrtc, 2017-08-24 18:52:00]

On 2017/08/24 14:18:31, kjellander_webrtc wrote:
> On 2017/08/24 14:06:05, kjellander_webrtc wrote:
> > lgtm, I updated the description for you.
> > 
> > wait for the trybot and also check it's build page, since there's a bug in
> > reporting failures on that particular step.
> 
> hmm, fails:
> 
> DEBUG:root:Running: ['gn', 'gen',
> '/b/s/w/ir/cache/builder/ios_api_framework/src/out_ios_libs/arm64_libs',
> '--args=target_os="ios" ios_enable_code_signing=false use_xcode_clang=true
> is_component_build=false is_debug=false target_cpu="arm64"
> ios_deployment_target="8.0" rtc_libvpx_build_vp9=false enable_ios_bitcode=true
> use_goma=true goma_dir="/b/s/w/ir/cache/goma_client" enable_stripping=true']
> Traceback (most recent call last):
>   File
>
"/b/s/w/ir/cache/builder/ios_api_framework/src/tools_webrtc/ios/build_ios_libs.py",
> line 255, in <module>
>     sys.exit(main())
>   File
>
"/b/s/w/ir/cache/builder/ios_api_framework/src/tools_webrtc/ios/build_ios_libs.py",
> line 177, in main
>     args.use_goma, gn_args, args.build_type == 'static_only')
>   File
>
"/b/s/w/ir/cache/builder/ios_api_framework/src/tools_webrtc/ios/build_ios_libs.py",
> line 123, in BuildWebRTC
>     _RunCommand(cmd)
>   File
>
"/b/s/w/ir/cache/builder/ios_api_framework/src/tools_webrtc/ios/build_ios_libs.py",
> line 75, in _RunCommand
>     subprocess.check_call(cmd, cwd=WEBRTC_SRC_DIR)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
> line 535, in check_call
>     retcode = call(*popenargs, **kwargs)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
> line 522, in call
>     return Popen(*popenargs, **kwargs).wait()
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
> line 710, in __init__
>     errread, errwrite)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
> line 1335, in _execute_child
>     raise child_exception
> OSError: [Errno 2] No such file or directory
> 
> so not lgtm yet.

hm, I don't get it. I tried an identical build on my machine and it all passes.
Trying a second trybot run.
lgtm

[kjellander_webrtc, 2017-08-24 18:57:28]

The new trybot build is passing where the previous failed, so I'm submitting
this now.

[kjellander_webrtc, 2017-08-24 18:57:40]

Description was changed from

==========
Fix iOS API Framework build script after renaming objc targets.

This fixes the script after targets were renamed in
https://codereview.webrtc.org/3001023003/

BUG=webrtc:6412
NOTRY=True
==========

to

==========
Fix iOS API Framework build script after renaming objc targets.

This fixes the script after targets were renamed in
https://codereview.webrtc.org/3001023003/

BUG=webrtc:6412, chromium:758655
NOTRY=True
==========

[kjellander_webrtc, 2017-08-24 18:57:45]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-08-24 18:57:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-24 19:01:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1503601065540130, "parent_rev":
"05b07bb833328515f7e86b769a7660008f0f498e", "commit_rev":
"72ba795e298fded0650d24fc698fe19d50df1b73"}

[commit-bot: I haz the power, 2017-08-24 19:01:29]

Description was changed from

==========
Fix iOS API Framework build script after renaming objc targets.

This fixes the script after targets were renamed in
https://codereview.webrtc.org/3001023003/

BUG=webrtc:6412, chromium:758655
NOTRY=True
==========

to

==========
Fix iOS API Framework build script after renaming objc targets.

This fixes the script after targets were renamed in
https://codereview.webrtc.org/3001023003/

BUG=webrtc:6412, chromium:758655
NOTRY=True

Review-Url: https://codereview.webrtc.org/3005513002
Cr-Commit-Position: refs/heads/master@{#19500}
Committed:
https://chromium.googlesource.com/external/webrtc/+/72ba795e298fded0650d24fc6...
==========

[commit-bot: I haz the power, 2017-08-24 19:01:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/72ba795e298fded0650d24fc6...