Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 3005503002: Robustify the AEC3 inaudible echo detection (Closed)

Created:
3 years, 4 months ago by peah-webrtc
Modified:
3 years, 4 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Robustify the AEC3 inaudible echo detection This CL robustifies the inaudible echo detection in AEC3 such that a requirement is that either the render and capture signals are aligned or that a headset has been detected. This ensures that the inaudible detection has been able to base the desicion on reliable signals. BUG=webrtc:8150 Review-Url: https://codereview.webrtc.org/3005503002 Cr-Commit-Position: refs/heads/master@{#19491} Committed: https://chromium.googlesource.com/external/webrtc/+/85864be8ef21d00ffd2a9cf80ea03ac4d239e5f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
peah-webrtc
ivoc@: Could you please take a look at this CL?
3 years, 4 months ago (2017-08-24 05:13:04 UTC) #2
ivoc
lgtm!
3 years, 4 months ago (2017-08-24 07:08:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3005503002/1
3 years, 4 months ago (2017-08-24 12:59:14 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-24 13:01:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/85864be8ef21d00ffd2a9cf80...

Powered by Google App Engine
This is Rietveld 408576698