Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 3005263002: Implement googContentType GetStats metric reported on receive side. (Closed)

Created:
3 years, 3 months ago by ilnik
Modified:
3 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, kwiberg-webrtc, the sun, mflodman
Target Ref:
refs/branch-heads/62
Project:
webrtc
Visibility:
Public.

Description

Implement googContentType GetStats metric reported on receive side. Reported per video stream as a string. Merge into M62. Original was reviewed here: https://codereview.webrtc.org/3009793002 BUG=webrtc:8174, chromium:762876 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/3005263002 Cr-Commit-Position: refs/branch-heads/62@{#7} Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592} Committed: https://chromium.googlesource.com/external/webrtc/+/344afb52615f11c1007781d545d36efb20271c04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M webrtc/api/statstypes.h View 3 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/statstypes.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/video/video_content_type.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/api/video/video_content_type.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/call/video_receive_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/media/base/mediachannel.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/pc/statscollector.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ilnik
3 years, 3 months ago (2017-09-08 12:33:18 UTC) #2
tommi
lgtm
3 years, 3 months ago (2017-09-08 12:34:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3005263002/1
3 years, 3 months ago (2017-09-08 12:34:51 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 12:35:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/344afb52615f11c1007781d54...

Powered by Google App Engine
This is Rietveld 408576698