Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 3005213002: Rename isolated-script-test-chartjson-output to isolated-script-test-perf-output. (Closed)

Created:
3 years, 3 months ago by ehmaldonado_webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename isolated-script-test-chartjson-output to isolated-script-test-perf-output. This is needed after the flag was renamed in https://chromium.googlesource.com/chromium/tools/build/+/3e6978a8c02dabd44a76e239554131a1014065a7 BUG=webrtc:8215 NOTRY=True Review-Url: https://codereview.webrtc.org/3005213002 Cr-Commit-Position: refs/heads/master@{#19721} Committed: https://chromium.googlesource.com/external/webrtc/+/c4eee32b83fae7bbce394aaed239d6bcb53dd995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools_webrtc/gtest-parallel-wrapper.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools_webrtc/valgrind/webrtc_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
ehmaldonado_webrtc
3 years, 3 months ago (2017-09-06 22:28:58 UTC) #2
ehmaldonado_webrtc
3 years, 3 months ago (2017-09-06 22:31:22 UTC) #4
kjellander_webrtc
lgtm but please also mention that this is needed to unblock the DEPS auto-roller in ...
3 years, 3 months ago (2017-09-07 06:43:24 UTC) #5
ehmaldonado_webrtc
On 2017/09/07 06:43:24, kjellander_webrtc wrote: > lgtm but please also mention that this is needed ...
3 years, 3 months ago (2017-09-07 06:50:40 UTC) #7
oprypin_webrtc
On 2017/09/07 06:50:40, ehmaldonado_webrtc wrote: > On 2017/09/07 06:43:24, kjellander_webrtc wrote: > > lgtm but ...
3 years, 3 months ago (2017-09-07 07:05:43 UTC) #9
oprypin_webrtc
> linux_baremetal failure is > https://bugs.chromium.org/p/chromium/issues/detail?id=759571 And I accidentally ran luci.webrtc.try win_x64_win8 linux_ubsan mac_rel
3 years, 3 months ago (2017-09-07 07:11:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3005213002/1
3 years, 3 months ago (2017-09-07 07:31:03 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-09-07 07:34:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c4eee32b83fae7bbce394aaed...

Powered by Google App Engine
This is Rietveld 408576698