Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 3005153002: Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, charujain, perkj_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #1 id:1 of https://codereview.webrtc.org/3010143002/ ) Reason for revert: I will fix and reland. Original issue's description: > Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ ) > > Reason for revert: > Breaks google3 project. > > Original issue's description: > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread > > > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue. > > > > BUG=webrtc:8142, webrtc:8143, webrtc:8145 > > > > Review-Url: https://codereview.webrtc.org/3007473002 > > Cr-Commit-Position: refs/heads/master@{#19666} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa57f84eec4b082598 > > TBR=terelius@webrtc.org,nisse@webrtc.org,eladalon@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:8142, webrtc:8143, webrtc:8145 > > Review-Url: https://codereview.webrtc.org/3010143002 > Cr-Commit-Position: refs/heads/master@{#19672} > Committed: https://chromium.googlesource.com/external/webrtc/+/3eac8002db8fdf5124026d5377a1f3ec1d16bb0d TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:8142, webrtc:8143, webrtc:8145 Review-Url: https://codereview.webrtc.org/3005153002 Cr-Commit-Position: refs/heads/master@{#19690} Committed: https://chromium.googlesource.com/external/webrtc/+/d67cefbbeab0a092d1fa250c811c25733dced043

Patch Set 1 #

Patch Set 2 : RtcEventLog created on same thread as it's destroyed. #

Total comments: 1

Patch Set 3 : Reintroduce ptr_util.h. #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -539 lines) Patch
M webrtc/logging/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 7 chunks +317 lines, -84 lines 0 comments Download
D webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.h View 1 chunk +0 lines, -128 lines 0 comments Download
D webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.cc View 1 chunk +0 lines, -315 lines 0 comments Download
M webrtc/pc/peerconnection.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
eladalon
Created Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
3 years, 3 months ago (2017-09-05 12:32:36 UTC) #1
eladalon
I've made sure creation and destruction would happen on the same thread. PTAL. https://codereview.webrtc.org/3005153002/diff/160001/webrtc/pc/peerconnectionfactory.cc File ...
3 years, 3 months ago (2017-09-05 13:04:33 UTC) #3
terelius
lgtm, but please have a PeerConnection OWNER review those changes.
3 years, 3 months ago (2017-09-05 14:28:14 UTC) #4
perkj_webrtc
lgtm
3 years, 3 months ago (2017-09-05 15:07:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3005153002/200001
3 years, 3 months ago (2017-09-05 15:14:58 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:200001) as https://chromium.googlesource.com/external/webrtc/+/d67cefbbeab0a092d1fa250c811c25733dced043
3 years, 3 months ago (2017-09-05 15:15:09 UTC) #12
eladalon
3 years, 3 months ago (2017-09-05 15:33:41 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:200001) has been created in
https://codereview.webrtc.org/3007193002/ by eladalon@webrtc.org.

The reason for reverting is: Landed without CQ, which was unintended..

Powered by Google App Engine
This is Rietveld 408576698