Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 3004873002: Delete static method TaskQueue::IsCurrent. (Closed)

Created:
3 years, 3 months ago by nisse-webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete static method TaskQueue::IsCurrent. The static method takes a queue name as argument. Used only in one place, a DCHECK in IncomingVideoStream, which is converted to use the non-static version of IsCurrent. BUG=webrtc:8166 Review-Url: https://codereview.webrtc.org/3004873002 Cr-Commit-Position: refs/heads/master@{#19657} Committed: https://chromium.googlesource.com/external/webrtc/+/2c7b7a633f6a6aef4467cc3b35a056a4dcc9d619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -39 lines) Patch
M webrtc/common_video/incoming_video_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/task_queue.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/rtc_base/task_queue_gcd.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/rtc_base/task_queue_libevent.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M webrtc/rtc_base/task_queue_unittest.cc View 9 chunks +10 lines, -12 lines 0 comments Download
M webrtc/rtc_base/task_queue_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nisse-webrtc
PTAL. Any reason to keep the method static bool IsCurrent(const char* queue_name); ? The more ...
3 years, 3 months ago (2017-08-30 08:38:11 UTC) #2
tommi
lgtm fwiw
3 years, 3 months ago (2017-08-30 09:49:56 UTC) #3
magjed_webrtc
webrtc/common_video/incoming_video_stream.cc lgtm
3 years, 3 months ago (2017-08-30 11:29:30 UTC) #4
perkj_webrtc
lgtm. Will you also update Chromes header file? It use a copy of the header ...
3 years, 3 months ago (2017-09-04 08:37:54 UTC) #5
nisse-webrtc
On 2017/09/04 08:37:54, perkj_webrtc wrote: > lgtm. Will you also update Chromes header file? It ...
3 years, 3 months ago (2017-09-04 08:44:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3004873002/1
3 years, 3 months ago (2017-09-04 09:43:32 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-04 12:18:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/2c7b7a633f6a6aef4467cc3b3...

Powered by Google App Engine
This is Rietveld 408576698