Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 3004813002: neteq_rtpplay: Fix a bug in the matlab plotting function (Closed)

Created:
3 years, 3 months ago by hlundin-webrtc
Modified:
3 years, 3 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

neteq_rtpplay: Fix a bug in the matlab plotting function This CL fixes a small bug, causing the matlab plot script to contain empty vectors. Also, the script file name is fixed, to avoid two periods (.) in the file name; matlab did not like that. BUG=none Review-Url: https://codereview.webrtc.org/3004813002 Cr-Commit-Position: refs/heads/master@{#19586} Committed: https://chromium.googlesource.com/external/webrtc/+/f09c904dd12aecfd7bd632ed53a10d02ccb7ef2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
hlundin-webrtc
Ivo, PTAL at this bugfix.
3 years, 3 months ago (2017-08-29 15:03:31 UTC) #3
ivoc
lgtm!
3 years, 3 months ago (2017-08-29 15:19:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3004813002/1
3 years, 3 months ago (2017-08-29 15:32:02 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-08-29 16:14:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f09c904dd12aecfd7bd632ed5...

Powered by Google App Engine
This is Rietveld 408576698