Use flag name without 'no' prefix only if it exists

Use flag name without 'no' prefix only if it exists

Before this change it was impossible to use flag names that start with "no", e.g. --noise_file

BUG=webrtc:8202
Review-Url: https://codereview.webrtc.org/3004363002
Cr-Commit-Position: refs/heads/master@{#19678}
Committed: https://chromium.googlesource.com/external/webrtc/+/31377a2a103f040c3c4f0b1947d69657233c21a2

[oprypin_webrtc, 2017-09-04 17:49:57]

Patchset #2 (id:20001) has been deleted

[oprypin_webrtc, 2017-09-04 17:50:28]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-04 17:50:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[oprypin_webrtc, 2017-09-04 17:50:48]

Description was changed from

==========
Use flag name without 'no' prefix only if it exists

BUG=webrtc:8202
==========

to

==========
Use flag name without 'no' prefix only if it exists

BUG=webrtc:8202
==========

[oprypin_webrtc, 2017-09-04 17:50:48]

oprypin@webrtc.org changed reviewers:
+ kwiberg@webrtc.org, terelius@webrtc.org

[oprypin_webrtc, 2017-09-04 17:53:34]

Description was changed from

==========
Use flag name without 'no' prefix only if it exists

BUG=webrtc:8202
==========

to

==========
Use flag name without 'no' prefix only if it exists

Before this change it was impossible to use flag names that start with "no",
e.g. --noise_file

BUG=webrtc:8202
==========

[commit-bot: I haz the power, 2017-09-04 20:22:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-04 20:22:02]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[kwiberg-webrtc, 2017-09-04 23:30:39]

lgtm

The question is about a property of the code that isn't affected by this CL.

https://codereview.webrtc.org/3004363002/diff/1/webrtc/rtc_base/flags.cc
File webrtc/rtc_base/flags.cc (right):

https://codereview.webrtc.org/3004363002/diff/1/webrtc/rtc_base/flags.cc#newc...
webrtc/rtc_base/flags.cc:155: }
Wait... what? Do we just *ignore* the "no" prefix? So that -foo and -nofoo mean
the same thing?

[oprypin_webrtc, 2017-09-05 06:54:16]

https://codereview.webrtc.org/3004363002/diff/1/webrtc/rtc_base/flags.cc
File webrtc/rtc_base/flags.cc (right):

https://codereview.webrtc.org/3004363002/diff/1/webrtc/rtc_base/flags.cc#newc...
webrtc/rtc_base/flags.cc:155: }
On 2017/09/04 23:30:39, kwiberg-webrtc wrote:
> Wait... what? Do we just *ignore* the "no" prefix? So that -foo and -nofoo
mean
> the same thing?

Yeah that also threw me off. This variable is more like... is_false, judging
from its usages.
I just re-checked that it works correctly.

[oprypin_webrtc, 2017-09-05 06:54:22]

The CQ bit was checked by oprypin@webrtc.org

[commit-bot: I haz the power, 2017-09-05 06:54:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-05 06:56:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1504594462327190, "parent_rev":
"6af0cbf4b02da1faf01011da81d97e1e0593b2ca", "commit_rev":
"31377a2a103f040c3c4f0b1947d69657233c21a2"}

[commit-bot: I haz the power, 2017-09-05 06:56:47]

Description was changed from

==========
Use flag name without 'no' prefix only if it exists

Before this change it was impossible to use flag names that start with "no",
e.g. --noise_file

BUG=webrtc:8202
==========

to

==========
Use flag name without 'no' prefix only if it exists

Before this change it was impossible to use flag names that start with "no",
e.g. --noise_file

BUG=webrtc:8202

Review-Url: https://codereview.webrtc.org/3004363002
Cr-Commit-Position: refs/heads/master@{#19678}
Committed:
https://chromium.googlesource.com/external/webrtc/+/31377a2a103f040c3c4f0b194...
==========

[commit-bot: I haz the power, 2017-09-05 06:56:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/31377a2a103f040c3c4f0b194...