Utilizing the AEC3 config struct for constants.

webrtc/modules/audio_processing/aec3/echo_remover.cc

Index: webrtc/modules/audio_processing/aec3/echo_remover.cc
diff --git a/webrtc/modules/audio_processing/aec3/echo_remover.cc b/webrtc/modules/audio_processing/aec3/echo_remover.cc
index a67a04e4e346e700d271cd5f7688fed0cac8267f..46ee8e2fc7b97ad06074a4d8b9310d857f8619eb 100644
--- a/webrtc/modules/audio_processing/aec3/echo_remover.cc
+++ b/webrtc/modules/audio_processing/aec3/echo_remover.cc
@@ -86,6 +86,7 @@ class EchoRemoverImpl final : public EchoRemover {
   bool echo_leakage_detected_ = false;
   AecState aec_state_;
   EchoRemoverMetrics metrics_;
+  const AudioProcessing::Config::EchoCanceller3 config_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(EchoRemoverImpl);
 };
@@ -101,10 +102,12 @@ EchoRemoverImpl::EchoRemoverImpl(
       optimization_(DetectOptimization()),
       sample_rate_hz_(sample_rate_hz),
       subtractor_(data_dumper_.get(), optimization_),
-      suppression_gain_(optimization_),
+      suppression_gain_(config, optimization_),
       cng_(optimization_),
       suppression_filter_(sample_rate_hz_),
-      aec_state_(0.8f) {
+      residual_echo_estimator_(config_),

[hlundin-webrtc, 2017/08/23 14:52:22]

This is probably a bug. I guess you would be using the default values for
config_ rather than the ones passed through config.

[peah-webrtc, 2017/08/24 07:00:52]

Thanks!!! That definitely was a bug. Good find! I'll change the code so that
config_ is set first. That should minimize the risk for error.

+      aec_state_(config),
+      config_(config) {
   RTC_DCHECK(ValidFullBandRate(sample_rate_hz));
 }