Utilizing the AEC3 config struct for constants.

webrtc/modules/audio_processing/aec3/echo_remover.cc

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #include "webrtc/modules/audio_processing/aec3/echo_remover.h"
@@ skipping 68 matching lines @@
   Subtractor subtractor_;
   SuppressionGain suppression_gain_;
   ComfortNoiseGenerator cng_;
   SuppressionFilter suppression_filter_;
   RenderSignalAnalyzer render_signal_analyzer_;
   OutputSelector output_selector_;
   ResidualEchoEstimator residual_echo_estimator_;
   bool echo_leakage_detected_ = false;
   AecState aec_state_;
   EchoRemoverMetrics metrics_;
+  const AudioProcessing::Config::EchoCanceller3 config_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(EchoRemoverImpl);
 };
 
 int EchoRemoverImpl::instance_count_ = 0;
 
 EchoRemoverImpl::EchoRemoverImpl(
     const AudioProcessing::Config::EchoCanceller3& config,
     int sample_rate_hz)
     : fft_(),
       data_dumper_(
           new ApmDataDumper(rtc::AtomicOps::Increment(&instance_count_))),
       optimization_(DetectOptimization()),
       sample_rate_hz_(sample_rate_hz),
       subtractor_(data_dumper_.get(), optimization_),
-      suppression_gain_(optimization_),
+      suppression_gain_(config, optimization_),
       cng_(optimization_),
       suppression_filter_(sample_rate_hz_),
-      aec_state_(0.8f) {
+      residual_echo_estimator_(config_),

[hlundin-webrtc, 2017/08/23 14:52:22]

This is probably a bug. I guess you would be using the default values for
config_ rather than the ones passed through config.

[peah-webrtc, 2017/08/24 07:00:52]

Thanks!!! That definitely was a bug. Good find! I'll change the code so that
config_ is set first. That should minimize the risk for error.

+      aec_state_(config),
+      config_(config) {
   RTC_DCHECK(ValidFullBandRate(sample_rate_hz));
 }
 
 EchoRemoverImpl::~EchoRemoverImpl() = default;
 
 void EchoRemoverImpl::ProcessCapture(
     const rtc::Optional<size_t>& echo_path_delay_samples,
     const EchoPathVariability& echo_path_variability,
     bool capture_signal_saturation,
     const RenderBuffer& render_buffer,
@@ skipping 122 matching lines @@
 
 }  // namespace
 
 EchoRemover* EchoRemover::Create(
     const AudioProcessing::Config::EchoCanceller3& config,
     int sample_rate_hz) {
   return new EchoRemoverImpl(config, sample_rate_hz);
 }
 
 }  // namespace webrtc