Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3003653002:
Enable the HW VideoToolbox encoder on mac. (Closed)
|
Created:
3 years, 4 months ago by kthelgason Modified:
3 years, 4 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionEnable the HW VideoToolbox encoder on mac.
This CL was originally submitted by an external contributor in
https://chromium-review.googlesource.com/c/external/webrtc/+/582051.
I have rebased it to the new ObjC encoder class.
BUG=webrtc:8022
Review-Url: https://codereview.webrtc.org/3003653002
Cr-Commit-Position: refs/heads/master@{#19486}
Committed: https://chromium.googlesource.com/external/webrtc/+/a4955b4d9a0ef84ffe1aa262a38f77740f53fa4d
Patch Set 1 #Patch Set 2 : fix oops #Patch Set 3 : Make sure to compile this only on mac #Messages
Total messages: 22 (18 generated)
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/24178)
The CQ bit was checked by kthelgason@webrtc.org
The CQ bit was unchecked by kthelgason@webrtc.org
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/27407)
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kthelgason@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL
lgtm
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1503571820688940,
"parent_rev": "1cdddc96fa2f81219bb363f540af8dfb822afbb3", "commit_rev":
"a4955b4d9a0ef84ffe1aa262a38f77740f53fa4d"}
Message was sent while issue was closed.
Description was changed from ========== Enable the HW VideoToolbox encoder on mac. This CL was originally submitted by an external contributor in https://chromium-review.googlesource.com/c/external/webrtc/+/582051. I have rebased it to the new ObjC encoder class. BUG=webrtc:8022 ========== to ========== Enable the HW VideoToolbox encoder on mac. This CL was originally submitted by an external contributor in https://chromium-review.googlesource.com/c/external/webrtc/+/582051. I have rebased it to the new ObjC encoder class. BUG=webrtc:8022 Review-Url: https://codereview.webrtc.org/3003653002 Cr-Commit-Position: refs/heads/master@{#19486} Committed: https://chromium.googlesource.com/external/webrtc/+/a4955b4d9a0ef84ffe1aa262a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/a4955b4d9a0ef84ffe1aa262a... |
