Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 3003563002: Remove unnecessary release call in EglRenderer. (Closed)

Created:
3 years, 4 months ago by sakal
Modified:
3 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unnecessary release call in EglRenderer. VideoSink is not assumed to take ownership of the frame, so it is not necessary to release it unless it is retained for future use. BUG=webrtc:7749 Review-Url: https://codereview.webrtc.org/3003563002 Cr-Commit-Position: refs/heads/master@{#19440} Committed: https://chromium.googlesource.com/external/webrtc/+/c614823fa35cd25df3c3cbcf2872e279098c7025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/sdk/android/api/org/webrtc/EglRenderer.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
sakal
PTAL
3 years, 4 months ago (2017-08-21 14:34:11 UTC) #4
magjed_webrtc
lgtm
3 years, 4 months ago (2017-08-21 15:03:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3003563002/1
3 years, 4 months ago (2017-08-22 07:17:37 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-22 07:22:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c614823fa35cd25df3c3cbcf2...

Powered by Google App Engine
This is Rietveld 408576698