Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 3003533002: Android: Fix synchronization problems in VideoFrame release. (Closed)

Created:
3 years, 4 months ago by sakal
Modified:
3 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Fix synchronization problems in VideoFrame release. Also fixes a small bug in EglRenderer where if it was passed a custom frame, it would leak a reference. BUG=b/64887218 Review-Url: https://codereview.webrtc.org/3003533002 Cr-Commit-Position: refs/heads/master@{#19432} Committed: https://chromium.googlesource.com/external/webrtc/+/2fe9dfae209e7ae6ce9bea087da9f14f7178b9ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M webrtc/sdk/android/api/org/webrtc/EglRenderer.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/I420BufferImpl.java View 2 chunks +8 lines, -3 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/NV12Buffer.java View 3 chunks +9 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/TextureBufferImpl.java View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sakal
PTAL
3 years, 4 months ago (2017-08-21 13:28:12 UTC) #3
magjed_webrtc
lgtm
3 years, 4 months ago (2017-08-21 14:54:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3003533002/1
3 years, 4 months ago (2017-08-21 14:54:57 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 15:03:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/2fe9dfae209e7ae6ce9bea087...

Powered by Google App Engine
This is Rietveld 408576698