Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 3003303002: Made the AEC3 alignment mandatory for using the adaptive filter delay (Closed)

Created:
3 years, 4 months ago by peah-webrtc
Modified:
3 years, 4 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Made the AEC3 alignment a mandatory for using the adaptive filter delay This CL ensures that the adaptive filter delay is not used for fine tune echo removal unless the render and capture signals have been properly aligned. BUG=webrtc:8189 Review-Url: https://codereview.webrtc.org/3003303002 Cr-Commit-Position: refs/heads/master@{#19492} Committed: https://chromium.googlesource.com/external/webrtc/+/b1737fc198ca768abdb6c0753e4f4cda5766aff6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
peah-webrtc
ivoc@: Could you please take a look at this CL?
3 years, 4 months ago (2017-08-24 05:03:37 UTC) #3
ivoc
lgtm!
3 years, 4 months ago (2017-08-24 07:07:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3003303002/20001
3 years, 4 months ago (2017-08-24 12:59:35 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-08-24 13:02:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/b1737fc198ca768abdb6c0753...

Powered by Google App Engine
This is Rietveld 408576698