Android: Add common function for adding/releasing native reference

Android: Add common function for adding/releasing native reference

This CL introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043
Review-Url: https://codereview.webrtc.org/3003213002
Cr-Commit-Position: refs/heads/master@{#19547}
Committed: https://chromium.googlesource.com/external/webrtc/+/b1c7453bfa4c7d369069e6dd77e849994f0f1427

[magjed_webrtc, 2017-08-23 13:19:57]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 13:20:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2017-08-23 13:21:43]

Description was changed from

==========
Android: Don't check ref count when releasing PeerConnectionInterface

This CL also introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043
==========

to

==========
Android: Don't check ref count when releasing PeerConnectionInterface

This CL fixes a bug in PeerConnection.freePeerConnection, see the webrtc
issue for more information.

This CL also introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043
==========

[commit-bot: I haz the power, 2017-08-23 16:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 16:19:08]

Dry run: Try jobs failed on following builders:
  android_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/bu...)

[magjed_webrtc, 2017-08-24 13:28:12]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2017-08-24 13:29:18]

Sami - please take a look.

[sakal, 2017-08-25 13:19:39]

lgtm with nits addressed

https://codereview.webrtc.org/3003213002/diff/1/webrtc/sdk/android/src/java/o...
File webrtc/sdk/android/src/java/org/webrtc/JniCommon.java (right):

https://codereview.webrtc.org/3003213002/diff/1/webrtc/sdk/android/src/java/o...
webrtc/sdk/android/src/java/org/webrtc/JniCommon.java:15: static native void
nativeAddRef(long nativeRefCountedPointer);
nit: comment that the pointer is a reference to rtc::RefCountInterface*

https://codereview.webrtc.org/3003213002/diff/1/webrtc/sdk/android/src/jni/jn...
File webrtc/sdk/android/src/jni/jni_helpers.cc (right):

https://codereview.webrtc.org/3003213002/diff/1/webrtc/sdk/android/src/jni/jn...
webrtc/sdk/android/src/jni/jni_helpers.cc:389: JOW(void, JniCommon_nativeAddRef)
nit: I don't really like adding these here, can you create a new file instead?

[magjed_webrtc, 2017-08-25 15:50:25]

Description was changed from

==========
Android: Don't check ref count when releasing PeerConnectionInterface

This CL fixes a bug in PeerConnection.freePeerConnection, see the webrtc
issue for more information.

This CL also introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043
==========

to

==========
Android: Don't check ref count when releasing PeerConnectionInterface

This CL introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043
==========

[magjed_webrtc, 2017-08-27 15:42:10]

Description was changed from

==========
Android: Don't check ref count when releasing PeerConnectionInterface

This CL introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043
==========

to

==========
Android: Add common function for adding/releasing native reference

This CL introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043
==========

[magjed_webrtc, 2017-08-27 16:02:01]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-27 16:02:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-27 16:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-27 16:24:38]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-08-27 20:44:32]

https://codereview.webrtc.org/3003213002/diff/1/webrtc/sdk/android/src/java/o...
File webrtc/sdk/android/src/java/org/webrtc/JniCommon.java (right):

https://codereview.webrtc.org/3003213002/diff/1/webrtc/sdk/android/src/java/o...
webrtc/sdk/android/src/java/org/webrtc/JniCommon.java:15: static native void
nativeAddRef(long nativeRefCountedPointer);
On 2017/08/25 13:19:39, sakal wrote:
> nit: comment that the pointer is a reference to rtc::RefCountInterface*

Done.

https://codereview.webrtc.org/3003213002/diff/1/webrtc/sdk/android/src/jni/jn...
File webrtc/sdk/android/src/jni/jni_helpers.cc (right):

https://codereview.webrtc.org/3003213002/diff/1/webrtc/sdk/android/src/jni/jn...
webrtc/sdk/android/src/jni/jni_helpers.cc:389: JOW(void, JniCommon_nativeAddRef)
On 2017/08/25 13:19:39, sakal wrote:
> nit: I don't really like adding these here, can you create a new file instead?

Done.

[magjed_webrtc, 2017-08-27 20:45:10]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2017-08-27 20:45:11]

The patchset sent to the CQ was uploaded after l-g-t-m from sakal@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3003213002/#ps40001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-08-27 20:45:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-27 20:47:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1503866710916000,
"parent_rev": "a4804dea9148e7d134a9c5305ef831bc89167533", "commit_rev":
"b1c7453bfa4c7d369069e6dd77e849994f0f1427"}

[commit-bot: I haz the power, 2017-08-27 20:47:26]

Description was changed from

==========
Android: Add common function for adding/releasing native reference

This CL introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043
==========

to

==========
Android: Add common function for adding/releasing native reference

This CL introduces common functions for adding and releasing
native references to reduce the number of JNI functions.

BUG=webrtc:8043

Review-Url: https://codereview.webrtc.org/3003213002
Cr-Commit-Position: refs/heads/master@{#19547}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b1c7453bfa4c7d369069e6dd7...
==========

[commit-bot: I haz the power, 2017-08-27 20:47:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/b1c7453bfa4c7d369069e6dd7...