Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 3002963002: Revert of Stop silently accepting unsupported flags in test binaries (Closed)

Created:
3 years, 4 months ago by oprypin_webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, hlundin-webrtc, ehmaldonado_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Stop silently accepting unsupported flags in test binaries (patchset #5 id:150001 of https://codereview.webrtc.org/2968003003/ ) Reason for revert: Causes failures on perf bots https://luci-milo.appspot.com/buildbot/client.webrtc.perf/Mac%2010.11/3567 Original issue's description: > Stop silently accepting unsupported flags in test binaries > > Instead explicitly ignore only the flags we know should be ignored. > > BUG=webrtc:7568 > > Review-Url: https://codereview.webrtc.org/2968003003 > Cr-Commit-Position: refs/heads/master@{#19412} > Committed: https://chromium.googlesource.com/external/webrtc/+/a2782f6f5d350e423b8166d603f44e17e1d7540b TBR=kjellander@webrtc.org,henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7568 Review-Url: https://codereview.webrtc.org/3002963002 Cr-Commit-Position: refs/heads/master@{#19413} Committed: https://chromium.googlesource.com/external/webrtc/+/d64072c598875cdf3a8ce5806d3410125363596d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M tools_webrtc/gtest-parallel-wrapper.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools_webrtc/valgrind/webrtc_tests.py View 2 chunks +0 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/test/test_main.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
oprypin_webrtc
Created Revert of Stop silently accepting unsupported flags in test binaries
3 years, 4 months ago (2017-08-18 14:22:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002963002/1
3 years, 4 months ago (2017-08-18 14:22:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/d64072c598875cdf3a8ce5806d3410125363596d
3 years, 4 months ago (2017-08-18 14:22:45 UTC) #6
kjellander_webrtc
Meh, too bad. Bitten by the small inconsistencies between trybots and perf bots. We really ...
3 years, 4 months ago (2017-08-18 18:55:14 UTC) #7
oprypin_webrtc
On 2017/08/18 18:55:14, kjellander_webrtc wrote: > Meh, too bad. Bitten by the small inconsistencies between ...
3 years, 4 months ago (2017-08-18 19:04:41 UTC) #8
oprypin_webrtc
3 years, 4 months ago (2017-08-22 14:32:26 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2999383002/ by oprypin@webrtc.org.

The reason for reverting is: Relanding without changes.
Problem with unused flags was fixed in
https://codereview.webrtc.org/2998143002/.

Powered by Google App Engine
This is Rietveld 408576698