Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 3002583002: Ensure UIView.layer is accessed on main thread. (Closed)

Created:
3 years, 4 months ago by andersc
Modified:
3 years, 4 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ensure UIView.layer is accessed on main thread. BUG=webrtc:7829 Review-Url: https://codereview.webrtc.org/3002583002 Cr-Commit-Position: refs/heads/master@{#19345} Committed: https://chromium.googlesource.com/external/webrtc/+/c288dab6e26f85b80b191b06beeffc1fcf3af5d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M webrtc/sdk/objc/Framework/Classes/UI/RTCCameraPreviewView.m View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
andersc
Fix for accessing the layer method off the main thread.
3 years, 4 months ago (2017-08-15 07:23:49 UTC) #7
kthelgason
lgtm lgtm, thanks for fixing this!
3 years, 4 months ago (2017-08-15 07:33:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002583002/1
3 years, 4 months ago (2017-08-15 07:33:21 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-15 07:36:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c288dab6e26f85b80b191b06b...

Powered by Google App Engine
This is Rietveld 408576698