Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 3002443002: dart-lang/async: Fix types in typed_wrapper/stream_test.dart

Created:
3 years, 4 months ago by Bill Hesse
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix types in typed_wrapper/stream_test.dart With Dart version 1.25.0-dev.10.0, some conversions from Stream<Object> to TypeSafeStream<int> are failing. Changed some Stream<Object> to Stream<int>. If this is not the intent of the test, and the conversion should succeed, it needs to be fixed in the library. BUG=https://github.com/dart-lang/async/issues/35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/typed_wrapper/stream_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bill Hesse
3 years, 4 months ago (2017-08-11 08:50:30 UTC) #2
Lasse Reichstein Nielsen
I believe this is a bug in the library (or test) then. The typed wrapper ...
3 years, 4 months ago (2017-08-17 09:32:08 UTC) #4
Bill Hesse
On 2017/08/17 09:32:08, Lasse Reichstein Nielsen wrote: > I believe this is a bug in ...
3 years, 3 months ago (2017-09-19 14:28:21 UTC) #5
nweiz
On 2017/09/19 14:28:21, Bill Hesse wrote: > On 2017/08/17 09:32:08, Lasse Reichstein Nielsen wrote: > ...
3 years, 3 months ago (2017-09-20 22:28:08 UTC) #6
Bill Hesse
On 2017/09/20 22:28:08, nweiz wrote: > On 2017/09/19 14:28:21, Bill Hesse wrote: > > On ...
3 years, 3 months ago (2017-09-20 22:45:52 UTC) #7
nweiz
3 years, 3 months ago (2017-09-21 00:29:28 UTC) #8
I'm following up on the GitHub issue.

Powered by Google App Engine
This is Rietveld 408576698