Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 3002263002: Add support for RGB frames in MediaCodecVideoEncoder. (Closed)

Created:
3 years, 3 months ago by sakal
Modified:
3 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add support for RGB frames in MediaCodecVideoEncoder. BUG=webrtc:7749 Review-Url: https://codereview.webrtc.org/3002263002 Cr-Commit-Position: refs/heads/master@{#19554} Committed: https://chromium.googlesource.com/external/webrtc/+/160e32c34f629be1fc7e634a085d9dc70a77b908

Patch Set 1 #

Patch Set 2 : Comment literals #

Total comments: 2

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/RendererCommon.java View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
sakal
PTAL
3 years, 3 months ago (2017-08-25 08:44:29 UTC) #2
magjed_webrtc
lgtm https://codereview.webrtc.org/3002263002/diff/40001/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right): https://codereview.webrtc.org/3002263002/diff/40001/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java#newcode619 webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:619: drawer.drawTexture(textureBuffer, new Matrix(), width, height, 0 /* viewportX ...
3 years, 3 months ago (2017-08-25 13:15:43 UTC) #4
sakal
https://codereview.webrtc.org/3002263002/diff/40001/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right): https://codereview.webrtc.org/3002263002/diff/40001/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java#newcode619 webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:619: drawer.drawTexture(textureBuffer, new Matrix(), width, height, 0 /* viewportX */, ...
3 years, 3 months ago (2017-08-28 08:06:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002263002/60001
3 years, 3 months ago (2017-08-28 09:38:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002263002/60001
3 years, 3 months ago (2017-08-28 09:39:27 UTC) #17
commit-bot: I haz the power
3 years, 3 months ago (2017-08-28 09:41:52 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/160e32c34f629be1fc7e634a0...

Powered by Google App Engine
This is Rietveld 408576698