Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3002213002:
Refactor some loops and remove double iteration. (Closed)
|
Created:
3 years, 4 months ago by kthelgason Modified:
3 years, 3 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRefactor some loops and remove double iteration.
This CL is a minor refactoring to clean up and modernize some code
in webrtcvideoengine.
BUG=None
Review-Url: https://codereview.webrtc.org/3002213002
Cr-Commit-Position: refs/heads/master@{#19660}
Committed: https://chromium.googlesource.com/external/webrtc/+/0c88a504120738f1d7371bfbf748b17bab7be81d
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
kthelgason@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL when time allows.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/24374) presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20801)
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27263)
The CQ bit was checked by kthelgason@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org Link to the patchset: https://codereview.webrtc.org/3002213002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1504525080582910,
"parent_rev": "6ff8f96baf339475fca80643bcd9d41e56f9fc4e", "commit_rev":
"0c88a504120738f1d7371bfbf748b17bab7be81d"}
Message was sent while issue was closed.
Description was changed from ========== Refactor some loops and remove double iteration. This CL is a minor refactoring to clean up and modernize some code in webrtcvideoengine. BUG=None ========== to ========== Refactor some loops and remove double iteration. This CL is a minor refactoring to clean up and modernize some code in webrtcvideoengine. BUG=None Review-Url: https://codereview.webrtc.org/3002213002 Cr-Commit-Position: refs/heads/master@{#19660} Committed: https://chromium.googlesource.com/external/webrtc/+/0c88a504120738f1d7371bfbf... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/0c88a504120738f1d7371bfbf... |
