Fix bugs in HardwareVideoDecoder reinitialization.

Fix bugs in HardwareVideoDecoder reinitialization.

Fixes bug where callback is set to null on reinitialization. Also fixes
a race condition where callback can be null in onTextureFrameAvailable.

BUG=webrtc:8124
Review-Url: https://codereview.webrtc.org/3002093002
Cr-Commit-Position: refs/heads/master@{#19493}
Committed: https://chromium.googlesource.com/external/webrtc/+/6c36dcb324f8dbcefd906ff00c656ca60c9be348

[sakal, 2017-08-22 11:10:15]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2017-08-22 11:10:16]

PTAL

[magjed_webrtc, 2017-08-24 10:52:24]

https://codereview.webrtc.org/3002093002/diff/1/webrtc/sdk/android/src/java/o...
File webrtc/sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java (right):

https://codereview.webrtc.org/3002093002/diff/1/webrtc/sdk/android/src/java/o...
webrtc/sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java:127: private
final Object callbackLock = new Object();
Please get rid of the lock and use SurfaceTextureHelper to synchronize instead,
e.g. stopListening/startListening has the guarantee you need.

[sakal, 2017-08-24 11:24:00]

I also went through all the variables and commented on their thread safety. I
also removed some duplicate nullings.

https://codereview.webrtc.org/3002093002/diff/1/webrtc/sdk/android/src/java/o...
File webrtc/sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java (right):

https://codereview.webrtc.org/3002093002/diff/1/webrtc/sdk/android/src/java/o...
webrtc/sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java:127: private
final Object callbackLock = new Object();
On 2017/08/24 10:52:24, magjed_webrtc wrote:
> Please get rid of the lock and use SurfaceTextureHelper to synchronize
instead,
> e.g. stopListening/startListening has the guarantee you need.

Done.

[magjed_webrtc, 2017-08-24 11:53:48]

lgtm

[sakal, 2017-08-24 12:19:59]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2017-08-24 12:20:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-24 13:04:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503577199468730,
"parent_rev": "b1737fc198ca768abdb6c0753e4f4cda5766aff6", "commit_rev":
"6c36dcb324f8dbcefd906ff00c656ca60c9be348"}

[commit-bot: I haz the power, 2017-08-24 13:04:03]

Description was changed from

==========
Fix bugs in HardwareVideoDecoder reinitialization.

Fixes bug where callback is set to null on reinitialization. Also fixes
a race condition where callback can be null in onTextureFrameAvailable.

BUG=webrtc:8124
==========

to

==========
Fix bugs in HardwareVideoDecoder reinitialization.

Fixes bug where callback is set to null on reinitialization. Also fixes
a race condition where callback can be null in onTextureFrameAvailable.

BUG=webrtc:8124

Review-Url: https://codereview.webrtc.org/3002093002
Cr-Commit-Position: refs/heads/master@{#19493}
Committed:
https://chromium.googlesource.com/external/webrtc/+/6c36dcb324f8dbcefd906ff00...
==========

[commit-bot: I haz the power, 2017-08-24 13:04:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/6c36dcb324f8dbcefd906ff00...