Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 3001693002: AppRTCMobile: Use high resolution app icon on retina screens. (Closed)

Created:
3 years, 4 months ago by andersc
Modified:
3 years, 4 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

AppRTCMobile: Use high resolution app icon on retina screens. Finally, no more hurting your eyes when looking at the app icon on a retina device. BUG=None TBR=magjed@webrtc.org Review-Url: https://codereview.webrtc.org/3001693002 Cr-Commit-Position: refs/heads/master@{#19351} Committed: https://chromium.googlesource.com/external/webrtc/+/b5ed905ce78334bbeb7b40f58bcd1ec455cca7a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/examples/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/Info.plist View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/examples/objc/Icon-120.png View Binary file 0 comments Download
A webrtc/examples/objc/Icon-180.png View Binary file 0 comments Download

Messages

Total messages: 21 (15 generated)
andersc
🎉
3 years, 4 months ago (2017-08-15 09:38:06 UTC) #10
kthelgason
Amazing, thanks! LGTM
3 years, 4 months ago (2017-08-15 09:41:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001693002/1
3 years, 4 months ago (2017-08-15 09:41:19 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20180)
3 years, 4 months ago (2017-08-15 09:46:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001693002/1
3 years, 4 months ago (2017-08-15 11:04:39 UTC) #18
commit-bot: I haz the power
3 years, 4 months ago (2017-08-15 11:07:18 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b5ed905ce78334bbeb7b40f58...

Powered by Google App Engine
This is Rietveld 408576698