Roll chromium_revision f156b499f7..f439921f66 (493756:494089)

Roll chromium_revision f156b499f7..f439921f66 (493756:494089)

Change log: https://chromium.googlesource.com/chromium/src/+log/f156b499f7..f439921f66
Full diff: https://chromium.googlesource.com/chromium/src/+/f156b499f7..f439921f66

Changed dependencies:
* src/base: https://chromium.googlesource.com/chromium/src/base/+log/c9ab1936b1..feac46e933
* src/build: https://chromium.googlesource.com/chromium/src/build/+log/5fecec2d69..221820676e
* src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/bf72566bf8..e437e37fec
* src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/1330967db2..3f5325f618
* src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/0a591a99a3..058ff821a8
* src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0eeb5baed7..122dd5e91b
* src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/3136678749..e78bdaf8db
DEPS diff: https://chromium.googlesource.com/chromium/src/+/f156b499f7..f439921f66/DEPS

Clang version changed 309984:310694
Details: https://chromium.googlesource.com/chromium/src/+/f156b499f7..f439921f66/tools/clang/scripts/update.py

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3001673002
Cr-Commit-Position: refs/heads/master@{#19350}
Committed: https://chromium.googlesource.com/external/webrtc/+/1bf0ff36eafd22dadaa24fb964cacc96606bd725

[ehmaldonado_webrtc, 2017-08-14 17:59:31]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-14 17:59:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-14 18:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-14 18:20:05]

Dry run: Try jobs failed on following builders:
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/28544)

[ehmaldonado_webrtc, 2017-08-14 18:41:27]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-08-15 08:47:16]

lgtm, seems like flaky tests are causing the red bot.

[ehmaldonado_webrtc, 2017-08-15 09:07:34]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-08-15 09:07:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-15 10:16:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1502788054636670,
"parent_rev": "53d76c619034785ce3d1472539d0792194a4a0ce", "commit_rev":
"1bf0ff36eafd22dadaa24fb964cacc96606bd725"}

[commit-bot: I haz the power, 2017-08-15 10:16:56]

Description was changed from

==========
Roll chromium_revision f156b499f7..f439921f66 (493756:494089)

Change log:
https://chromium.googlesource.com/chromium/src/+log/f156b499f7..f439921f66
Full diff:
https://chromium.googlesource.com/chromium/src/+/f156b499f7..f439921f66

Changed dependencies:
* src/base:
https://chromium.googlesource.com/chromium/src/base/+log/c9ab1936b1..feac46e933
* src/build:
https://chromium.googlesource.com/chromium/src/build/+log/5fecec2d69..221820676e
* src/ios:
https://chromium.googlesource.com/chromium/src/ios/+log/bf72566bf8..e437e37fec
* src/testing:
https://chromium.googlesource.com/chromium/src/testing/+log/1330967db2..3f532...
* src/third_party:
https://chromium.googlesource.com/chromium/src/third_party/+log/0a591a99a3..0...
* src/third_party/catapult:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
* src/tools:
https://chromium.googlesource.com/chromium/src/tools/+log/3136678749..e78bdaf8db
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/f156b499f7..f439921f66/DEPS

Clang version changed 309984:310694
Details:
https://chromium.googlesource.com/chromium/src/+/f156b499f7..f439921f66/tools...

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal
==========

to

==========
Roll chromium_revision f156b499f7..f439921f66 (493756:494089)

Change log:
https://chromium.googlesource.com/chromium/src/+log/f156b499f7..f439921f66
Full diff:
https://chromium.googlesource.com/chromium/src/+/f156b499f7..f439921f66

Changed dependencies:
* src/base:
https://chromium.googlesource.com/chromium/src/base/+log/c9ab1936b1..feac46e933
* src/build:
https://chromium.googlesource.com/chromium/src/build/+log/5fecec2d69..221820676e
* src/ios:
https://chromium.googlesource.com/chromium/src/ios/+log/bf72566bf8..e437e37fec
* src/testing:
https://chromium.googlesource.com/chromium/src/testing/+log/1330967db2..3f532...
* src/third_party:
https://chromium.googlesource.com/chromium/src/third_party/+log/0a591a99a3..0...
* src/third_party/catapult:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
* src/tools:
https://chromium.googlesource.com/chromium/src/tools/+log/3136678749..e78bdaf8db
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/f156b499f7..f439921f66/DEPS

Clang version changed 309984:310694
Details:
https://chromium.googlesource.com/chromium/src/+/f156b499f7..f439921f66/tools...

TBR=
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3001673002
Cr-Commit-Position: refs/heads/master@{#19350}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1bf0ff36eafd22dadaa24fb96...
==========

[commit-bot: I haz the power, 2017-08-15 10:16:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1bf0ff36eafd22dadaa24fb96...

[kjellander_webrtc, 2017-08-21 04:23:19]

On 2017/08/15 10:16:57, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/external/webrtc/+/1bf0ff36eafd22dadaa24fb96...

It appears we need to check for Clang here (see
https://bugs.chromium.org/p/chromium/issues/detail?id=756840).
Also: always file a bug for fixing the code when disabling a warning like this.
If it could have been done in the first place we could have avoided the reverted
roll etc.