Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 3001343002: Remove GC prologue and epilogue callbacks. (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove GC prologue and epilogue callbacks. These should have been removed along with weak reference set support in 4992bc72a0565cff507fb8aa94ce3fd330467cf9 since they serve no other purpose. Committed: https://github.com/dart-lang/sdk/commit/14b57825445389964310381e9098d62b24ff3704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -331 lines) Patch
M runtime/include/dart_api.h View 1 chunk +0 lines, -43 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 8 chunks +9 lines, -169 lines 0 comments Download
M runtime/vm/gc_marker.h View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/gc_marker.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M runtime/vm/heap.h View 3 chunks +1 line, -5 lines 0 comments Download
M runtime/vm/heap.cc View 5 chunks +8 lines, -13 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +0 lines, -18 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/pages.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/pages.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/scavenger.h View 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/scavenger.cc View 6 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 4 months ago (2017-08-22 01:09:09 UTC) #2
siva
STV
3 years, 4 months ago (2017-08-22 17:23:54 UTC) #3
rmacnak
3 years, 4 months ago (2017-08-22 18:20:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14b57825445389964310381e9098d62b24ff3704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698