Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 3001333002: Fix rtc::CurrentThreadId() on Android (Closed)

Created:
3 years, 4 months ago by magjed_webrtc
Modified:
3 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix rtc::CurrentThreadId() on Android We have been using the Linux way of getting the thread id on Android, even though we have a special code path for getting it on Android. BUG=webrtc:8110 Review-Url: https://codereview.webrtc.org/3001333002 Cr-Commit-Position: refs/heads/master@{#19494} Committed: https://chromium.googlesource.com/external/webrtc/+/d950d9eda1c970d87d0d67c1fd46f06735030438

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/rtc_base/platform_thread.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 13 (9 generated)
magjed_webrtc
tommi - please take a look.
3 years, 4 months ago (2017-08-23 13:39:37 UTC) #7
tommi
lgtm https://codereview.webrtc.org/3001333002/diff/1/webrtc/rtc_base/platform_thread.cc File webrtc/rtc_base/platform_thread.cc (right): https://codereview.webrtc.org/3001333002/diff/1/webrtc/rtc_base/platform_thread.cc#newcode32 webrtc/rtc_base/platform_thread.cc:32: #elif defined(WEBRTC_ANDROID) ah, so WEBRTC_LINUX is defined for ...
3 years, 4 months ago (2017-08-23 13:53:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001333002/1
3 years, 4 months ago (2017-08-24 12:53:35 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-24 13:41:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d950d9eda1c970d87d0d67c1f...

Powered by Google App Engine
This is Rietveld 408576698