Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 3001313002: Uncomment thread-check in AudioSendStream::OnPacketFeedbackVector() (Closed)

Created:
3 years, 4 months ago by eladalon
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Uncomment thread-check in AudioSendStream::OnPacketFeedbackVector() The thread-check should be pass unit-tests, following https://codereview.webrtc.org/2998923002/. BUG=webrtc:7405 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/3001313002 Cr-Commit-Position: refs/heads/master@{#19498} Committed: https://chromium.googlesource.com/external/webrtc/+/3651fdd1372b027a81b5652abe93b5c6ea3de442

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M webrtc/audio/audio_send_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
eladalon
PTAL
3 years, 4 months ago (2017-08-21 08:45:52 UTC) #2
nisse-webrtc
lgtm
3 years, 4 months ago (2017-08-23 12:34:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001313002/20001
3 years, 4 months ago (2017-08-24 13:58:34 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-24 14:26:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/3651fdd1372b027a81b5652ab...

Powered by Google App Engine
This is Rietveld 408576698