Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h

Issue 3001183002: Make a friendlier RTCVideoCodecInfo initializer. (Closed)
Patch Set: Mark -init as unavailable. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h
index 7f678b97594f5385c3dd65f99ec5e72ee70eb60c..d7c7a5fe38aa22efadc92d81093fa4f5f3308ded 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h
@@ -100,9 +100,15 @@ typedef NS_ENUM(NSUInteger, RTCVideoCodecMode) {
RTC_EXPORT
@interface RTCVideoCodecInfo : NSObject
+- (instancetype)init NS_UNAVAILABLE;
+
- (instancetype)initWithPayload:(NSInteger)payload
name:(NSString *)name
- parameters:(NSDictionary<NSString *, NSString *> *)parameters;
+ parameters:(NSDictionary<NSString *, NSString *> *)parameters
kthelgason 2017/08/18 12:25:44 Are we ever expecting this to be called for any re
andersc 2017/08/18 13:30:37 You're right, this is only used internally. Moving
+ NS_DESIGNATED_INITIALIZER;
+
+- (instancetype)initWithName:(NSString *)name
+ parameters:(nullable NSDictionary<NSString *, NSString *> *)parameters;
@property(nonatomic, readonly) NSInteger payload;
@property(nonatomic, readonly) NSString *name;

Powered by Google App Engine
This is Rietveld 408576698