Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 3001083002: Revert of Adding support for Unified Plan offer/answer negotiation. (Closed)

Created:
3 years, 4 months ago by olka_webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding support for Unified Plan offer/answer negotiation. (patchset #9 id:500001 of https://codereview.webrtc.org/2991693002/ ) Reason for revert: BUG=webrtc:8108 : breaks Clang build. Original issue's description: > Adding support for Unified Plan offer/answer negotiation to the mediasession layer. > > This layer takes in a simplified "options" struct and the current local description, > and generates a new offer/answer. Previously the options struct assumed there would > only be one media description per media type (audio/video), but it now supports > N number of audio/video descriptions. > > The |add_legacy_stream| options is removed from the mediasession.cc/.h > in this CL. > > The next step is to add the ability for PeerConnection/WebRtcSession to create > "options" to represent multiple RtpTransceivers, and apply the Unified Plan > descriptions correctly. Right now, only Plan B descriptions will be > generated in unit tests. > > BUG=chromium:465349 > > Review-Url: https://codereview.webrtc.org/2991693002 > Cr-Commit-Position: refs/heads/master@{#19343} > Committed: https://chromium.googlesource.com/external/webrtc/+/a77e6bbd30276bdc5b30f2cbc1e92ca181ae76f0 TBR=deadbeef@webrtc.org,zhihuang@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:465349 Review-Url: https://codereview.webrtc.org/3001083002 Cr-Commit-Position: refs/heads/master@{#19384} Committed: https://chromium.googlesource.com/external/webrtc/+/3c747665d06f6db9e0e570fbb43f122f228419d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1722 lines, -2793 lines) Patch
M webrtc/pc/mediasession.h View 7 chunks +113 lines, -125 lines 0 comments Download
M webrtc/pc/mediasession.cc View 24 chunks +591 lines, -789 lines 0 comments Download
M webrtc/pc/mediasession_unittest.cc View 101 chunks +363 lines, -826 lines 0 comments Download
M webrtc/pc/peerconnection.h View 3 chunks +34 lines, -17 lines 0 comments Download
M webrtc/pc/peerconnection.cc View 8 chunks +235 lines, -324 lines 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 4 chunks +173 lines, -270 lines 0 comments Download
M webrtc/pc/webrtcsession_unittest.cc View 60 chunks +165 lines, -392 lines 0 comments Download
M webrtc/pc/webrtcsessiondescriptionfactory.cc View 8 chunks +48 lines, -50 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
olka_webrtc
Created Revert of Adding support for Unified Plan offer/answer negotiation.
3 years, 4 months ago (2017-08-17 11:33:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001083002/1
3 years, 4 months ago (2017-08-17 11:33:29 UTC) #3
commit-bot: I haz the power
3 years, 4 months ago (2017-08-17 13:50:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/3c747665d06f6db9e0e570fbb...

Powered by Google App Engine
This is Rietveld 408576698