Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 3001023003: Rename all objc targets to be suffixed for consistency (Closed)

Created:
3 years, 4 months ago by kthelgason
Modified:
3 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), henrika_webrtc, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, mflodman, magjed_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489} Committed: https://chromium.googlesource.com/external/webrtc/+/36d658d085913b1916416fde3656a65eb61421e5

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -77 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 5 chunks +10 lines, -10 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 1 31 chunks +57 lines, -57 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
kthelgason
PTAL
3 years, 4 months ago (2017-08-17 10:50:47 UTC) #6
kjellander_webrtc
lgtm but make sure to run linux_internal trybot as well.
3 years, 4 months ago (2017-08-17 11:02:27 UTC) #7
kjellander_webrtc
On 2017/08/17 11:02:27, kjellander_webrtc wrote: > lgtm but make sure to run linux_internal trybot as ...
3 years, 3 months ago (2017-08-24 11:31:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001023003/20001
3 years, 3 months ago (2017-08-24 11:59:14 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-08-24 12:43:59 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/36d658d085913b1916416fde3...

Powered by Google App Engine
This is Rietveld 408576698