Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 3000993002: Implement QP parsing in VideoDecoderWrapper. (Closed)

Created:
3 years, 4 months ago by sakal
Modified:
3 years, 4 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Implement QP parsing in VideoDecoderWrapper. BUG=webrtc:7760 NOTRY=True Review-Url: https://codereview.webrtc.org/3000993002 Cr-Commit-Position: refs/heads/master@{#19378} Committed: https://chromium.googlesource.com/external/webrtc/+/4dee3444936f27c08e736c58c36fa37802298a6f

Patch Set 1 : Undo unrelated change #

Patch Set 2 : Remove whitespace #

Total comments: 2

Patch Set 3 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
M webrtc/sdk/android/src/jni/videodecoderwrapper.h View 3 chunks +6 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/videodecoderwrapper.cc View 1 2 6 chunks +58 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
sakal
PTAL
3 years, 4 months ago (2017-08-16 10:45:19 UTC) #3
kthelgason
https://codereview.webrtc.org/3000993002/diff/40001/webrtc/sdk/android/src/jni/videodecoderwrapper.cc File webrtc/sdk/android/src/jni/videodecoderwrapper.cc (right): https://codereview.webrtc.org/3000993002/diff/40001/webrtc/sdk/android/src/jni/videodecoderwrapper.cc#newcode75 webrtc/sdk/android/src/jni/videodecoderwrapper.cc:75: qp_parsing_enabled_ = true; It's quite unclear what this depends ...
3 years, 4 months ago (2017-08-16 13:57:58 UTC) #4
sakal
https://codereview.webrtc.org/3000993002/diff/40001/webrtc/sdk/android/src/jni/videodecoderwrapper.cc File webrtc/sdk/android/src/jni/videodecoderwrapper.cc (right): https://codereview.webrtc.org/3000993002/diff/40001/webrtc/sdk/android/src/jni/videodecoderwrapper.cc#newcode75 webrtc/sdk/android/src/jni/videodecoderwrapper.cc:75: qp_parsing_enabled_ = true; On 2017/08/16 13:57:58, kthelgason wrote: > ...
3 years, 4 months ago (2017-08-16 14:47:07 UTC) #5
kthelgason
lgtm
3 years, 4 months ago (2017-08-17 07:31:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3000993002/60001
3 years, 4 months ago (2017-08-17 07:32:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/3510)
3 years, 4 months ago (2017-08-17 08:02:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3000993002/60001
3 years, 4 months ago (2017-08-17 08:50:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_rel/builds/3563)
3 years, 4 months ago (2017-08-17 09:01:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3000993002/60001
3 years, 4 months ago (2017-08-17 09:15:33 UTC) #17
commit-bot: I haz the power
3 years, 4 months ago (2017-08-17 09:18:10 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/4dee3444936f27c08e736c58c...

Powered by Google App Engine
This is Rietveld 408576698