Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 3000653002: Workaround for PacketBuffer bug. (Closed)

Created:
3 years, 4 months ago by philipel
Modified:
3 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/branch-heads/61
Project:
webrtc
Visibility:
Public.

Description

Workaround for PacketBuffer bug. This is a merge to M61. There exist a bug in the video_coding::PacketBuffer which triggers when a frame is the same size as the buffer. A trivial workaround is to increase the start size to something big so that this never happens in practice. The bug has been fixed but to avoid non-trivial merges we use this workaround instead for M61. BUG=webrtc:8028, chromium:752886 R=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/3000653002 . Cr-Commit-Position: refs/branch-heads/61@{#4} Cr-Branched-From: 83dc6b6f5380d7c03f5ebfe2553bf4a3147e2d1c-refs/heads/master@{#19063} Committed: https://chromium.googlesource.com/external/webrtc/+/371062bf35921ebeb33b3a66cdf58d1028d8e9a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/video/rtp_video_stream_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (5 generated)
stefan-webrtc
lgtm
3 years, 4 months ago (2017-08-10 08:35:18 UTC) #2
philipel
3 years, 4 months ago (2017-08-14 14:52:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
371062bf35921ebeb33b3a66cdf58d1028d8e9a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698