Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 3000383002: Robustified the detection of linear filter quality in AEC3 (Closed)

Created:
3 years, 4 months ago by peah-webrtc
Modified:
3 years, 4 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Robustified the detection of linear filter quality in AEC3 BUG=webrtc:8141 Review-Url: https://codereview.webrtc.org/3000383002 Cr-Commit-Position: refs/heads/master@{#19468} Committed: https://chromium.googlesource.com/external/webrtc/+/0fcb74d7490f975c717c85ade354ccfe50d1b77a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_processing/aec3/aec_state.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
peah-webrtc
Hi, Could you please take a look at this CL?
3 years, 4 months ago (2017-08-23 14:07:40 UTC) #3
ivoc
lgtm!
3 years, 4 months ago (2017-08-23 14:10:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3000383002/1
3 years, 4 months ago (2017-08-23 14:17:37 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-23 16:18:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/0fcb74d7490f975c717c85ade...

Powered by Google App Engine
This is Rietveld 408576698