H264: Don't disable compiler warning by using NO_THREAD_SAFETY_ANALYSIS.

H264: Don't disable compiler warning by using NO_THREAD_SAFETY_ANALYSIS.

The LockManagerOperation global function uses void** which does not work
well with the thread_annotations.h macros and produce compiler warnings
on clang (chromium default). Workarounds to this is hacky and unhelpful
so we disable the analysis for this function, which isn't helpful in
this case anyway.

webrtc_h264_config is no longer needed and is removed.

BUG=webrtc:8090, webrtc:8119
Review-Url: https://codereview.webrtc.org/3000263002
Cr-Commit-Position: refs/heads/master@{#19425}
Committed: https://chromium.googlesource.com/external/webrtc/+/228fb0e1ec5f25018d112bf891bf8cca4a038fed

[hbos, 2017-08-21 08:51:04]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 08:51:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2017-08-21 08:52:10]

hbos@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[hbos, 2017-08-21 08:52:10]

Please take a look, kjellander.
(cc ehmaldonado)

[kjellander_webrtc, 2017-08-21 08:54:26]

lgtm

[hbos, 2017-08-21 08:55:04]

The CQ bit was unchecked by hbos@webrtc.org

[hbos, 2017-08-21 08:55:19]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2017-08-21 08:55:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 09:00:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 09:00:22]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20426)

[hbos, 2017-08-21 09:33:56]

hbos@webrtc.org changed reviewers:
+ sprang@webrtc.org

[hbos, 2017-08-21 09:33:56]

Please take a stamp, sprang.

[hbos, 2017-08-21 09:36:28]

On 2017/08/21 09:33:56, hbos wrote:
> Please take a stamp, sprang.

Should I add the two of us (sprang, hbos) to an OWNERS file in the
video_coding/codecs/h264 directory?

[sprang_webrtc, 2017-08-21 10:42:34]

On 2017/08/21 09:36:28, hbos wrote:
> On 2017/08/21 09:33:56, hbos wrote:
> > Please take a stamp, sprang.
> 
> Should I add the two of us (sprang, hbos) to an OWNERS file in the
> video_coding/codecs/h264 directory?

Makes sense to me

[sprang_webrtc, 2017-08-21 10:42:42]

lgtm

[hbos, 2017-08-21 11:45:14]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2017-08-21 11:45:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org,
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3000263002/#ps20001 (title:
"OWNERS file added")

[commit-bot: I haz the power, 2017-08-21 11:45:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 12:17:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503315914057300,
"parent_rev": "ed0e4366887137606fae2a57d7df1001848d21d1", "commit_rev":
"228fb0e1ec5f25018d112bf891bf8cca4a038fed"}

[commit-bot: I haz the power, 2017-08-21 12:17:35]

Description was changed from

==========
H264: Don't disable compiler warning by using NO_THREAD_SAFETY_ANALYSIS.

The LockManagerOperation global function uses void** which does not work
well with the thread_annotations.h macros and produce compiler warnings
on clang (chromium default). Workarounds to this is hacky and unhelpful
so we disable the analysis for this function, which isn't helpful in
this case anyway.

webrtc_h264_config is no longer needed and is removed.

BUG=8090, 8119
==========

to

==========
H264: Don't disable compiler warning by using NO_THREAD_SAFETY_ANALYSIS.

The LockManagerOperation global function uses void** which does not work
well with the thread_annotations.h macros and produce compiler warnings
on clang (chromium default). Workarounds to this is hacky and unhelpful
so we disable the analysis for this function, which isn't helpful in
this case anyway.

webrtc_h264_config is no longer needed and is removed.

BUG=8090, 8119

Review-Url: https://codereview.webrtc.org/3000263002
Cr-Commit-Position: refs/heads/master@{#19425}
Committed:
https://chromium.googlesource.com/external/webrtc/+/228fb0e1ec5f25018d112bf89...
==========

[commit-bot: I haz the power, 2017-08-21 12:17:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/228fb0e1ec5f25018d112bf89...

[hbos, 2017-08-21 13:27:12]

Description was changed from

==========
H264: Don't disable compiler warning by using NO_THREAD_SAFETY_ANALYSIS.

The LockManagerOperation global function uses void** which does not work
well with the thread_annotations.h macros and produce compiler warnings
on clang (chromium default). Workarounds to this is hacky and unhelpful
so we disable the analysis for this function, which isn't helpful in
this case anyway.

webrtc_h264_config is no longer needed and is removed.

BUG=8090, 8119

Review-Url: https://codereview.webrtc.org/3000263002
Cr-Commit-Position: refs/heads/master@{#19425}
Committed:
https://chromium.googlesource.com/external/webrtc/+/228fb0e1ec5f25018d112bf89...
==========

to

==========
H264: Don't disable compiler warning by using NO_THREAD_SAFETY_ANALYSIS.

The LockManagerOperation global function uses void** which does not work
well with the thread_annotations.h macros and produce compiler warnings
on clang (chromium default). Workarounds to this is hacky and unhelpful
so we disable the analysis for this function, which isn't helpful in
this case anyway.

webrtc_h264_config is no longer needed and is removed.

BUG=webrtc:8090, webrtc:8119

Review-Url: https://codereview.webrtc.org/3000263002
Cr-Commit-Position: refs/heads/master@{#19425}
Committed:
https://chromium.googlesource.com/external/webrtc/+/228fb0e1ec5f25018d112bf89...
==========