Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2999973002: Change ThreadChecker to SequencedTaskChecker in internal::Call (Closed)

Created:
3 years, 4 months ago by eladalon
Modified:
3 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change ThreadChecker to SequencedTaskChecker in internal::Call In preparation of running DirectTransport on a TaskQueue in unit-tests, change the thread-checkers to sequence-checkers. This is necessary for Mac and iOS, where the TaskQueue is guaranteed to run sequentially, but not guaranteed to do so on only one thread. TODO: Add the relevant BUGs. BUG=None Review-Url: https://codereview.webrtc.org/2999973002 Cr-Commit-Position: refs/heads/master@{#19404} Committed: https://chromium.googlesource.com/external/webrtc/+/f3f5c0e0317094a0c43749e9ab12cb8c5b181b94

Patch Set 1 #

Patch Set 2 : Fix BUILD.gn. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M webrtc/call/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/call/call.cc View 1 21 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
tommi
lgtm
3 years, 4 months ago (2017-08-18 08:17:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999973002/20001
3 years, 4 months ago (2017-08-18 08:36:58 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-18 09:47:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/f3f5c0e0317094a0c43749e9a...

Powered by Google App Engine
This is Rietveld 408576698