Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2999713002: Adding desugar as a dependency on android (Closed)

Created:
3 years, 4 months ago by mbonadei
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding desugar as a dependency on android BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2999713002 Cr-Commit-Position: refs/heads/master@{#19283} Committed: https://chromium.googlesource.com/external/webrtc/+/e9a40732f5c4da317145d4f12fc526a99ca2ff42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M DEPS View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mbonadei
In order to unblock the Chromium roll into WebRTC we have to add a dependency ...
3 years, 4 months ago (2017-08-09 11:43:24 UTC) #2
sakal
lgtm
3 years, 4 months ago (2017-08-09 11:48:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999713002/1
3 years, 4 months ago (2017-08-09 11:50:06 UTC) #6
ehmaldonado_webrtc
On 2017/08/09 11:48:12, sakal wrote: > lgtm lgtm. Have you tested if this unblocks the ...
3 years, 4 months ago (2017-08-09 11:50:21 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-08-09 11:53:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e9a40732f5c4da317145d4f12...

Powered by Google App Engine
This is Rietveld 408576698