Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 4 months ago by mbonadei Modified:
3 years, 3 months ago Reviewers:
ehmaldonado_webrtc, kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemoving EXPAT_RELATIVE_PATH and rtc_relative_path.
I think this was previously used in libjingle but it is not
used in WebRTC.
BUG=webrtc:8082
Review-Url: https://codereview.webrtc.org/2999703002
Cr-Commit-Position: refs/heads/master@{#19523}
Committed: https://chromium.googlesource.com/external/webrtc/+/cb2bbce4e1920c874c76dcfcc54d6c9922c4ea4d
Patch Set 1 #Patch Set 2 : Rebasing #
Created: 3 years, 3 months ago
Messages
Total messages: 21 (10 generated)
Description was changed from ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path BUG= ========== to ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path BUG=webrtc:8082 ==========
Description was changed from ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path BUG=webrtc:8082 ========== to ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path. I think this was previously used in libjingle but it is not used in WebRTC. BUG=webrtc:8082 ==========
mbonadei@webrtc.org changed reviewers: + ehmaldonado@webrtc.org
lgtm
Description was changed from ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path. I think this was previously used in libjingle but it is not used in WebRTC. BUG=webrtc:8082 ========== to ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path. I think this was previously used in libjingle but it is not used in WebRTC. BUG=webrtc:8082 NOTRY=True ==========
On 2017/08/09 11:22:43, ehmaldonado_webrtc wrote: > lgtm It turns out that this is used in third_party/libjingle_xmpp which is a chromium dependency. I think this should set by Chromium though, and not by WebRTC.
mbonadei@webrtc.org changed reviewers: + kjellander@webrtc.org
> It turns out that this is used in third_party/libjingle_xmpp which > is a chromium dependency. > > I think this should set by Chromium though, and not by WebRTC. Moving kjellander@ in the reviewer list because he has some context.
Correct, it was only used in the old XMPP code, which now has been moved out of WebRTC into Chromium's third_party/libjingle_xmpp dir instead. So we don't need this define anymore. Thanks for the cleanup. lgtm
Although, it seems it needs to be set in https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/BUILD.gn before this can land after looking at the Chromium trybot failures.
On 2017/08/14 10:48:59, kjellander_webrtc wrote: > Although, it seems it needs to be set in > https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/BUILD.gn before > this can land after looking at the Chromium trybot failures. Trybots are still red but it is my fault. I have to wait for the next Chromium roll.
On 2017/08/15 14:58:26, mbonadei wrote: > On 2017/08/14 10:48:59, kjellander_webrtc wrote: > > Although, it seems it needs to be set in > > https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/BUILD.gn > before > > this can land after looking at the Chromium trybot failures. > > Trybots are still red but it is my fault. I have to wait for the next Chromium > roll. I think I know why, I'll post in https://chromium-review.googlesource.com/c/615261
On 2017/08/15 14:58:26, mbonadei wrote: > On 2017/08/14 10:48:59, kjellander_webrtc wrote: > > Although, it seems it needs to be set in > > https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/BUILD.gn > before > > this can land after looking at the Chromium trybot failures. > > Trybots are still red but it is my fault. I have to wait for the next Chromium > roll. I think I know why, I'll post in https://chromium-review.googlesource.com/c/615261
Description was changed from ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path. I think this was previously used in libjingle but it is not used in WebRTC. BUG=webrtc:8082 NOTRY=True ========== to ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path. I think this was previously used in libjingle but it is not used in WebRTC. BUG=webrtc:8082 ==========
The CQ bit was checked by mbonadei@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from ehmaldonado@webrtc.org, kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/2999703002/#ps20001 (title: "Rebasing")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503669684465350,
"parent_rev": "5a0c4ed21977d18a5d80179e541d607834ea79a0", "commit_rev":
"cb2bbce4e1920c874c76dcfcc54d6c9922c4ea4d"}
Message was sent while issue was closed.
Description was changed from ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path. I think this was previously used in libjingle but it is not used in WebRTC. BUG=webrtc:8082 ========== to ========== Removing EXPAT_RELATIVE_PATH and rtc_relative_path. I think this was previously used in libjingle but it is not used in WebRTC. BUG=webrtc:8082 Review-Url: https://codereview.webrtc.org/2999703002 Cr-Commit-Position: refs/heads/master@{#19523} Committed: https://chromium.googlesource.com/external/webrtc/+/cb2bbce4e1920c874c76dcfcc... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/cb2bbce4e1920c874c76dcfcc... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
