Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2999613002: Minor improvements to VideoProcessorIntegrationTest. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor improvements to VideoProcessorIntegrationTest. * Create all encoders/decoders using factories. * Add ::Release() method, to mirror the existing ::Init(). * Remove unnecessary ::test prefixes. * Reorganize constants and members. * Remove extraneous packet loss rate assignments. * Remove members |start_frame_rate_| and |num_temporal_layers_|. * Explicitly give ::SetUpObjects(.) access to initial rates. * Change visualization output file names. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2999613002 Cr-Commit-Position: refs/heads/master@{#19326} Committed: https://chromium.googlesource.com/external/webrtc/+/77920a415bdbf71946125bc4bbdbe5b23e02e61a

Patch Set 1 #

Patch Set 2 : Reorder constants and remove unnecessary packet loss assignments. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : More cleanups in VideoProcessorIntegrationTest. #

Patch Set 6 : Set startBitrate, to fix tests. #

Patch Set 7 : Fix iOS. #

Patch Set 8 : Fix iOS more. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -159 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 2 3 4 5 6 20 chunks +106 lines, -135 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 2 3 4 5 6 7 5 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
brandtr
... and this followup, which is more interesting.
3 years, 4 months ago (2017-08-08 08:26:41 UTC) #2
brandtr
Reorder constants and remove unnecessary packet loss assignments.
3 years, 4 months ago (2017-08-08 10:43:31 UTC) #3
brandtr
Rebase.
3 years, 4 months ago (2017-08-08 15:37:05 UTC) #5
brandtr
Rebase.
3 years, 4 months ago (2017-08-09 10:51:59 UTC) #6
brandtr
Added some more cleanups.
3 years, 4 months ago (2017-08-09 11:18:24 UTC) #9
brandtr
Set startBitrate, to fix tests.
3 years, 4 months ago (2017-08-09 11:57:11 UTC) #10
brandtr
I just verified that the output of the VideoProcessorIntegrationTest is identical before and after this ...
3 years, 4 months ago (2017-08-10 08:11:02 UTC) #11
åsapersson
lgtm
3 years, 4 months ago (2017-08-11 13:13:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999613002/100001
3 years, 4 months ago (2017-08-11 13:24:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/22660)
3 years, 4 months ago (2017-08-11 13:27:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999613002/140001
3 years, 4 months ago (2017-08-11 14:45:37 UTC) #27
commit-bot: I haz the power
3 years, 4 months ago (2017-08-11 14:48:22 UTC) #30
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/77920a415bdbf71946125bc4b...

Powered by Google App Engine
This is Rietveld 408576698