Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2999343002: Fix compile error for the win_msvc_rel bot. (Closed)

Created:
3 years, 4 months ago by philipel
Modified:
3 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix compile error for the win_msvc_rel bot. During a period of about one month we have only built with clang and not msvc, and during this period code that does not build with msvc have been submitted. BUG=webrtc:8122 Review-Url: https://codereview.webrtc.org/2999343002 Cr-Commit-Position: refs/heads/master@{#19433} Committed: https://chromium.googlesource.com/external/webrtc/+/f0a1dd9e202d7d1c14611e1f2eda4fa42cd053a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/modules/remote_bitrate_estimator/test/estimators/bbr.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
philipel
Henrik, PTAL
3 years, 4 months ago (2017-08-21 13:33:48 UTC) #3
kjellander_webrtc
lgtm Please update CL description to something more descriptive.
3 years, 4 months ago (2017-08-21 13:39:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999343002/1
3 years, 4 months ago (2017-08-21 15:51:07 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 15:53:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f0a1dd9e202d7d1c14611e1f2...

Powered by Google App Engine
This is Rietveld 408576698