Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2998843002: Default enable content type rtp header extension (Closed)

Created:
3 years, 4 months ago by sprang_webrtc
Modified:
3 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, brandtr
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Default enable content type rtp header extension BUG=webrtc:7420 Review-Url: https://codereview.webrtc.org/2998843002 Cr-Commit-Position: refs/heads/master@{#19346} Committed: https://chromium.googlesource.com/external/webrtc/+/ee21f374cac86ab4f963caff17ab17770ad9d1ff

Patch Set 1 #

Patch Set 2 : remove dead code #

Patch Set 3 : Remove unit test for the removed code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -35 lines) Patch
M webrtc/media/engine/webrtcvideoengine.cc View 1 2 chunks +3 lines, -12 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine_unittest.cc View 1 2 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
sprang_webrtc
Let's also add content type header to list of capabilities. It's only two bytes per ...
3 years, 4 months ago (2017-08-11 12:49:13 UTC) #2
stefan-webrtc
lgtm
3 years, 4 months ago (2017-08-14 12:21:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998843002/1
3 years, 4 months ago (2017-08-14 12:22:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/15084)
3 years, 4 months ago (2017-08-14 12:26:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998843002/20001
3 years, 4 months ago (2017-08-14 12:31:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/28101)
3 years, 4 months ago (2017-08-14 12:38:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998843002/40001
3 years, 4 months ago (2017-08-15 08:30:10 UTC) #19
commit-bot: I haz the power
3 years, 4 months ago (2017-08-15 08:32:59 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/ee21f374cac86ab4f963caff1...

Powered by Google App Engine
This is Rietveld 408576698