Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2998793002:
Fix (1) EndToEndTest.InitialProbing and (2) EndToEndTest.TriggerMidCallProbing (Closed)
DescriptionFix (1) EndToEndTest.InitialProbing and (2) EndToEndTest.TriggerMidCallProbing
* EndToEndTest.InitialProbing had an uninitialized boolean.
* Both tests used RTC_DCHECK where one would normally expect an RTC_DCHECK.
BUG=webrtc:8085
Review-Url: https://codereview.webrtc.org/2998793002
Cr-Commit-Position: refs/heads/master@{#19309}
Committed: https://chromium.googlesource.com/external/webrtc/+/cf038f7eb6054f4e6286271440ed0488a3c7d18b
Patch Set 1 #Patch Set 2 : Fix lacking initialization of a bool. #
Total comments: 3
Patch Set 3 : Rebased #Messages
Total messages: 24 (12 generated)
eladalon@webrtc.org changed reviewers: + sprang@webrtc.org, stefan@webrtc.org
PTAL
P.S: Fixed indentation.
Patchset #1 (id:1) has been deleted
Description was changed from ========== Replace DCHECK with EXPECT in two end-to-end tests EndToEndTest.InitialProbing and EndToEndTest.TriggerMidCallProbing have RTC_DCHECK where one would normally expect an RTC_DCHECK. BUG=None ========== to ========== Fix (1) EndToEndTest.InitialProbing and (2) EndToEndTest.TriggerMidCallProbing * EndToEndTest.InitialProbing had an uninitialized boolean. * Both tests used RTC_DCHECK where one would normally expect an RTC_DCHECK. BUG=webrtc:8085 ==========
Also found an uninitialized boolean in one of these; fixed. https://codereview.webrtc.org/2998793002/diff/40001/webrtc/video/end_to_end_t... File webrtc/video/end_to_end_tests.cc (right): https://codereview.webrtc.org/2998793002/diff/40001/webrtc/video/end_to_end_t... webrtc/video/end_to_end_tests.cc:2310: *success_ = false; This line was missing from this test, though not from the next one. https://codereview.webrtc.org/2998793002/diff/40001/webrtc/video/end_to_end_t... webrtc/video/end_to_end_tests.cc:2334: bool success = false; This is not strictly necessary, because it happens in the ctor, but it avoids giving the reader a small heart-attack before he sees the ctor. https://codereview.webrtc.org/2998793002/diff/40001/webrtc/video/end_to_end_t... webrtc/video/end_to_end_tests.cc:2405: bool success = false; This is not strictly necessary, because it happens in the ctor, but it avoids giving the reader a small heart-attack before he sees the ctor.
lgtm
The CQ bit was checked by eladalon@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by eladalon@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2998793002/#ps60001 (title: "Rebased")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Note to self: Check if this fixes the memsan problem mentioned in the TODO above.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/26395)
The CQ bit was checked by eladalon@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...) android_compile_x86_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_rel...) android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/26464)
The CQ bit was checked by eladalon@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1502384778694460,
"parent_rev": "3bf97cf0602f150e05b5424735cced520aa0cfef", "commit_rev":
"cf038f7eb6054f4e6286271440ed0488a3c7d18b"}
Message was sent while issue was closed.
Description was changed from ========== Fix (1) EndToEndTest.InitialProbing and (2) EndToEndTest.TriggerMidCallProbing * EndToEndTest.InitialProbing had an uninitialized boolean. * Both tests used RTC_DCHECK where one would normally expect an RTC_DCHECK. BUG=webrtc:8085 ========== to ========== Fix (1) EndToEndTest.InitialProbing and (2) EndToEndTest.TriggerMidCallProbing * EndToEndTest.InitialProbing had an uninitialized boolean. * Both tests used RTC_DCHECK where one would normally expect an RTC_DCHECK. BUG=webrtc:8085 Review-Url: https://codereview.webrtc.org/2998793002 Cr-Commit-Position: refs/heads/master@{#19309} Committed: https://chromium.googlesource.com/external/webrtc/+/cf038f7eb6054f4e628627144... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/external/webrtc/+/cf038f7eb6054f4e628627144... |
