Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2998443002: Adding deadbeef@ as owner of Objc-C PeerConnection-related headers. (Closed)

Created:
3 years, 4 months ago by Taylor Brandstetter
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding deadbeef@ as owner of Objc-C PeerConnection-related headers. deadbeef@'s team in Kirkland works on the C++ PeerConnection implementation, and often makes changes to the Java/Obj-C binding code as new features are added. But the general Obj-C/Android owners are in Stockholm. So adding deadbeef@ as an owner of this code should help expedite code reviews for simple API changes. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2998443002 Cr-Commit-Position: refs/heads/master@{#19259} Committed: https://chromium.googlesource.com/external/webrtc/+/6327b6491e6c84fc451de445c17facbb50c58d9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
A webrtc/sdk/objc/Framework/Classes/PeerConnection/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Headers/WebRTC/OWNERS View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Taylor Brandstetter
PTAL. Is it ok to stick OWNERs files under "Framework", or do I need to ...
3 years, 4 months ago (2017-08-04 17:40:35 UTC) #2
tkchin_webrtc
On 2017/08/04 17:40:35, Taylor Brandstetter wrote: > PTAL. Is it ok to stick OWNERs files ...
3 years, 4 months ago (2017-08-04 23:00:14 UTC) #3
magjed_webrtc
On 2017/08/04 23:00:14, tkchin_webrtc wrote: > On 2017/08/04 17:40:35, Taylor Brandstetter wrote: > > PTAL. ...
3 years, 4 months ago (2017-08-05 14:38:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998443002/1
3 years, 4 months ago (2017-08-07 16:58:11 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-08-07 17:00:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6327b6491e6c84fc451de445c...

Powered by Google App Engine
This is Rietveld 408576698