Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2998403002: Android: Update convenience macro defining JNI-accessible methods (Closed)

Created:
3 years, 3 months ago by magjed_webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Update convenience macro defining JNI-accessible methods Update the name of the macro to something more descriptive and use variable length arguments to make it work better with autoformatting tools. BUG=None Review-Url: https://codereview.webrtc.org/2998403002 Cr-Commit-Position: refs/heads/master@{#19538} Committed: https://chromium.googlesource.com/external/webrtc/+/09f3f6eb268b7d84cc8aa2e36a84cf6380f74037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+671 lines, -308 lines) Patch
M webrtc/sdk/android/src/jni/androidhistogram_jni.cc View 1 chunk +20 lines, -6 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 1 chunk +12 lines, -11 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmetrics_jni.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource_jni.cc View 6 chunks +53 lines, -40 lines 0 comments Download
M webrtc/sdk/android/src/jni/jni_helpers.h View 1 chunk +2 lines, -14 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/androidnetworkmonitor_jni.cc View 3 chunks +23 lines, -14 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/audiotrack_jni.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/callsessionfilerotatinglogsink_jni.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/datachannel_jni.cc View 2 chunks +31 lines, -12 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/dtmfsender_jni.cc View 1 chunk +33 lines, -17 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/logging_jni.cc View 2 chunks +26 lines, -8 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/mediasource_jni.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/mediastream_jni.cc View 1 chunk +30 lines, -10 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/mediastreamtrack_jni.cc View 1 chunk +31 lines, -7 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/peerconnection_jni.cc View 12 chunks +134 lines, -45 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/peerconnectionfactory_jni.cc View 10 chunks +101 lines, -46 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/rtpreceiver_jni.cc View 3 chunks +39 lines, -14 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/rtpsender_jni.cc View 2 chunks +37 lines, -13 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/video_jni.cc View 3 chunks +22 lines, -14 lines 0 comments Download
M webrtc/sdk/android/src/jni/video_renderer_jni.cc View 1 chunk +25 lines, -14 lines 0 comments Download
M webrtc/sdk/android/src/jni/videodecoderwrapper.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M webrtc/sdk/android/src/jni/wrapped_native_i420_buffer.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
magjed_webrtc
Taylor - please take a look. I had some time over so I thought I ...
3 years, 3 months ago (2017-08-25 18:03:20 UTC) #7
Taylor Brandstetter
lgtm; thanks for doing this!
3 years, 3 months ago (2017-08-26 02:42:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998403002/1
3 years, 3 months ago (2017-08-26 10:23:19 UTC) #10
commit-bot: I haz the power
3 years, 3 months ago (2017-08-26 10:25:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/09f3f6eb268b7d84cc8aa2e36...

Powered by Google App Engine
This is Rietveld 408576698