Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2998353002:
Update video_replay tool to be able to dump .jpg files. (Closed)
DescriptionUpdate video_replay tool to be able to dump .jpg files.
BUG=None
Review-Url: https://codereview.webrtc.org/2998353002
Cr-Commit-Position: refs/heads/master@{#19521}
Committed: https://chromium.googlesource.com/external/webrtc/+/99b63455b758f508699125d383032141078361c0
Patch Set 1 #
Total comments: 4
Patch Set 2 : Feedback + Format #Patch Set 3 : Don't save on iOS #Patch Set 4 : iOS fix take 2 #
Messages
Total messages: 25 (12 generated)
philipel@webrtc.org changed reviewers: + ilnik@webrtc.org
On 2017/08/24 13:35:09, philipel wrote: lgtm
philipel@webrtc.org changed reviewers: + sprang@webrtc.org
Erik, PTAL
https://codereview.webrtc.org/2998353002/diff/1/webrtc/video/replay.cc File webrtc/video/replay.cc (right): https://codereview.webrtc.org/2998353002/diff/1/webrtc/video/replay.cc#newcod... webrtc/video/replay.cc:140: DEFINE_string(out_base, "", "Basename (excluding .yuv) for raw output"); You should also change a discription, since now it doesn't produce yuv but jpg files.
lgtm with nits https://codereview.webrtc.org/2998353002/diff/1/webrtc/video/replay.cc File webrtc/video/replay.cc (right): https://codereview.webrtc.org/2998353002/diff/1/webrtc/video/replay.cc#newcod... webrtc/video/replay.cc:182: filename << count_++ << "_" << video_frame.timestamp() << ".jpg"; nit: merge into single statement
https://codereview.webrtc.org/2998353002/diff/1/webrtc/video/replay.cc File webrtc/video/replay.cc (right): https://codereview.webrtc.org/2998353002/diff/1/webrtc/video/replay.cc#newcod... webrtc/video/replay.cc:140: DEFINE_string(out_base, "", "Basename (excluding .yuv) for raw output"); On 2017/08/24 14:47:46, ilnik wrote: > You should also change a discription, since now it doesn't produce yuv but jpg > files. Done. https://codereview.webrtc.org/2998353002/diff/1/webrtc/video/replay.cc#newcod... webrtc/video/replay.cc:182: filename << count_++ << "_" << video_frame.timestamp() << ".jpg"; On 2017/08/25 08:32:19, sprang_webrtc wrote: > nit: merge into single statement Done.
The CQ bit was checked by philipel@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org, ilnik@webrtc.org Link to the patchset: https://codereview.webrtc.org/2998353002/#ps20001 (title: "Feedback + Format")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/28538)
On 2017/08/25 09:46:38, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) > ios_dbg on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/28538) JpegFrameWriter is not available on iOS. Just ifdef exclude saving part for now. Later I will add dummy implementation for ios.
The CQ bit was checked by philipel@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org, ilnik@webrtc.org Link to the patchset: https://codereview.webrtc.org/2998353002/#ps40001 (title: "Don't save on iOS")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/22993)
The CQ bit was checked by philipel@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org, ilnik@webrtc.org Link to the patchset: https://codereview.webrtc.org/2998353002/#ps60001 (title: "iOS fix take 2")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1503668383337930,
"parent_rev": "9dbd084761208bd161f10a3b3bcb6295339c15e9", "commit_rev":
"99b63455b758f508699125d383032141078361c0"}
Message was sent while issue was closed.
Description was changed from ========== Update video_replay tool to be able to dump .jpg files. BUG=None ========== to ========== Update video_replay tool to be able to dump .jpg files. BUG=None Review-Url: https://codereview.webrtc.org/2998353002 Cr-Commit-Position: refs/heads/master@{#19521} Committed: https://chromium.googlesource.com/external/webrtc/+/99b63455b758f508699125d38... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/external/webrtc/+/99b63455b758f508699125d38... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
