Reimplement the builtin audio codec factories using the new stuff in api/

Reimplement the builtin audio codec factories using the new stuff in api/

The whole point of all the audio codec stuff we've recently published
in api/ is to function as lego bricks so that building stuff like our
builtin audio codec factories will be easy.

(This has landed once before, but got reverted because of Chromium test
failures---apparently, someone isn't ignoring the case of the codec names
like they're supposed to. The quick fix was to preserve the same case
used by the old implementation.)

BUG=webrtc:7821, webrtc:7822
Review-Url: https://codereview.webrtc.org/2998263002
Cr-Commit-Position: refs/heads/master@{#19512}
Committed: https://chromium.googlesource.com/external/webrtc/+/e5eb7247ffaefade251d9c8b4cc1df1530564482

[kwiberg-webrtc, 2017-08-22 21:51:12]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-22 21:51:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-22 22:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-22 22:46:08]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-24 12:06:49]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-24 12:06:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-08-24 12:07:47]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2017-08-24 12:10:42]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[kwiberg-webrtc, 2017-08-24 12:10:43]

PTAL. Patch set #1 is exactly as you reviewed it last time; patch set #2 fixes
the Chromium test failure according to my local testing.

[kwiberg-webrtc, 2017-08-24 12:12:41]

Description was changed from

==========
Reimplement the builtin audio codec factories using the new stuff in api/

The whole point of all the audio codec stuff we've recently published
in api/ is to function as lego bricks so that building stuff like our
builtin audio codec factories will be easy.

BUG=webrtc:7821, webrtc:7822
==========

to

==========
Reimplement the builtin audio codec factories using the new stuff in api/

The whole point of all the audio codec stuff we've recently published
in api/ is to function as lego bricks so that building stuff like our
builtin audio codec factories will be easy.

(This has landed once before, but got reverted because of Chromium test
failures---apparently, someone isn't ignoring the case of the codec names
like they're supposed to. The quick fix was to preserve the same case
used by the old implementation.)

BUG=webrtc:7821, webrtc:7822
==========

[commit-bot: I haz the power, 2017-08-24 12:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-24 12:52:04]

Dry run: This issue passed the CQ dry run.

[ossu, 2017-08-25 10:07:38]

Looked around and although it's at a few places still spelled g722, I don't
think they matter for this (i.e. it won't be visible e.g. in the SDP).

LGTM

[kwiberg-webrtc, 2017-08-25 10:08:03]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-08-25 10:08:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-08-25 10:10:02]

On 2017/08/25 10:07:38, ossu wrote:
> Looked around and although it's at a few places still spelled g722, I don't
> think they matter for this (i.e. it won't be visible e.g. in the SDP).
> 
> LGTM

Yes. I didn't attempt to fix all codec name strings---just the ones in
api/---because it wasn't necessary in order to make the new factory
implementations behave exactly like the old ones.

[commit-bot: I haz the power, 2017-08-25 10:10:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1503655683299170,
"parent_rev": "d1dd2f79e5f290ef0f21f5c050aa0111732a0f71", "commit_rev":
"e5eb7247ffaefade251d9c8b4cc1df1530564482"}

[commit-bot: I haz the power, 2017-08-25 10:10:57]

Description was changed from

==========
Reimplement the builtin audio codec factories using the new stuff in api/

The whole point of all the audio codec stuff we've recently published
in api/ is to function as lego bricks so that building stuff like our
builtin audio codec factories will be easy.

(This has landed once before, but got reverted because of Chromium test
failures---apparently, someone isn't ignoring the case of the codec names
like they're supposed to. The quick fix was to preserve the same case
used by the old implementation.)

BUG=webrtc:7821, webrtc:7822
==========

to

==========
Reimplement the builtin audio codec factories using the new stuff in api/

The whole point of all the audio codec stuff we've recently published
in api/ is to function as lego bricks so that building stuff like our
builtin audio codec factories will be easy.

(This has landed once before, but got reverted because of Chromium test
failures---apparently, someone isn't ignoring the case of the codec names
like they're supposed to. The quick fix was to preserve the same case
used by the old implementation.)

BUG=webrtc:7821, webrtc:7822

Review-Url: https://codereview.webrtc.org/2998263002
Cr-Commit-Position: refs/heads/master@{#19512}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e5eb7247ffaefade251d9c8b4...
==========

[commit-bot: I haz the power, 2017-08-25 10:10:59]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/e5eb7247ffaefade251d9c8b4...